Re: [PATCH v2 07/22] coredump: pin the protocol struct sizes

[R Nageswara Sastry <rnsastry@linux.ibm.com>]

On 20.08.2026 4:39 AM, Christian Brauner wrote:
> COREDUMP_REQ_SIZE_VER0 and COREDUMP_ACK_SIZE_VER0 define the initial
> struct sizes.
>
> Assert that both published sizes still match their structs. While at it
> fix some issues with docs.
>
> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
Tested-by: R Nageswara Sastry <rnsastry@linux.ibm.com>

System: ppc64le LPAR (IBM POWER), Linux 7.3-rc2
> ---
>   fs/coredump.c                 | 2 ++
>   include/uapi/linux/coredump.h | 4 ++--
>   2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/fs/coredump.c b/fs/coredump.c
> index 24a6405ea242..c696b46c97ff 100644
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -759,6 +759,8 @@ static inline bool coredump_sock_send(struct file *file, struct coredump_req *re
>   	return ret == sizeof(*req);
>   }
>   
> +static_assert(sizeof(struct coredump_req) == COREDUMP_REQ_SIZE_VER0);
> +static_assert(sizeof(struct coredump_ack) == COREDUMP_ACK_SIZE_VER0);
>   static_assert(sizeof(enum coredump_mark) == sizeof(__u32));
>   
>   static inline bool coredump_sock_mark(struct file *file, enum coredump_mark mark)
> diff --git a/include/uapi/linux/coredump.h b/include/uapi/linux/coredump.h
> index dc3789b78af0..662e0468da6e 100644
> --- a/include/uapi/linux/coredump.h
> +++ b/include/uapi/linux/coredump.h
> @@ -30,11 +30,11 @@ enum {
>    * member is set to the size of struct coredump_req and provides a hint
>    * to userspace how much data can be read. Userspace may use MSG_PEEK to
>    * peek the size of struct coredump_req and then choose to consume it in
> - * one go. Userspace may also simply read a COREDUMP_ACK_SIZE_VER0
> + * one go. Userspace may also simply read a COREDUMP_REQ_SIZE_VER0
>    * request. If the size the kernel sends is larger userspace simply
>    * discards any remaining data.
>    *
> - * The coredump_req->mask member is set to the currently know features.
> + * The coredump_req->mask member is set to the currently known features.
>    * Userspace may only set coredump_ack->mask to the bits raised by the
>    * kernel in coredump_req->mask.
>    *
>
-- 
Thanks and Regards
R.Nageswara Sastry