Re: [PATCH v2 08/22] coredump: move the negotiated mask into struct coredump_params

[R Nageswara Sastry <rnsastry@linux.ibm.com>]

On 20.08.2026 4:39 AM, Christian Brauner wrote:
> The coredump server negotiates a set of COREDUMP_* options with the
> kernel. The core dump path cannot see them though.
>
> Move the mask into struct coredump_params to make them available.
>
> No functional change.
>
> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
Tested-by: R Nageswara Sastry <rnsastry@linux.ibm.com>

System: ppc64le LPAR (IBM POWER), Linux 7.3-rc2
> ---
>   fs/coredump.c            | 15 +++++++--------
>   include/linux/coredump.h |  2 ++
>   2 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/fs/coredump.c b/fs/coredump.c
> index c696b46c97ff..156688be3df0 100644
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -100,7 +100,6 @@ struct core_name {
>   	unsigned int core_pipe_limit;
>   	bool core_dumped;
>   	enum coredump_type_t core_type;
> -	u64 mask;
>   };
>   
>   static int expand_corename(struct core_name *cn, int size)
> @@ -245,9 +244,9 @@ static bool coredump_parse(struct core_name *cn, struct coredump_params *cprm,
>   	int pid_in_pattern = 0;
>   	int err = 0;
>   
> -	cn->mask = COREDUMP_KERNEL;
> +	cprm->mask = COREDUMP_KERNEL;
>   	if (core_pipe_limit)
> -		cn->mask |= COREDUMP_WAIT;
> +		cprm->mask |= COREDUMP_WAIT;
>   	cn->used = 0;
>   	cn->corename = NULL;
>   	cn->core_pipe_limit = 0;
> @@ -860,7 +859,7 @@ static bool coredump_sock_request(struct core_name *cn, struct coredump_params *
>   		return false;
>   	}
>   
> -	cn->mask = ack.mask;
> +	cprm->mask = ack.mask;
>   	return coredump_sock_mark(cprm->file, COREDUMP_MARK_REQACK);
>   }
>   
> @@ -1129,7 +1128,7 @@ static void do_coredump(struct core_name *cn, struct coredump_params *cprm,
>   	}
>   
>   	/* Don't even generate the coredump. */
> -	if (cn->mask & COREDUMP_REJECT)
> +	if (cprm->mask & COREDUMP_REJECT)
>   		return;
>   
>   	/* get us an unshared descriptor table; almost always a no-op */
> @@ -1137,13 +1136,13 @@ static void do_coredump(struct core_name *cn, struct coredump_params *cprm,
>   	if (unshare_files())
>   		return;
>   
> -	if ((cn->mask & COREDUMP_KERNEL) && !coredump_write(cn, cprm, binfmt))
> +	if ((cprm->mask & COREDUMP_KERNEL) && !coredump_write(cn, cprm, binfmt))
>   		return;
>   
>   	coredump_sock_shutdown(cprm->file);
>   
>   	/* Let the parent know that a coredump was generated. */
> -	if (cn->mask & COREDUMP_USERSPACE)
> +	if (cprm->mask & COREDUMP_USERSPACE)
>   		cn->core_dumped = true;
>   
>   	/*
> @@ -1151,7 +1150,7 @@ static void do_coredump(struct core_name *cn, struct coredump_params *cprm,
>   	 * or usermodehelper to finish before exiting so it can e.g.,
>   	 * inspect /proc/<pid>.
>   	 */
> -	if (cn->mask & COREDUMP_WAIT) {
> +	if (cprm->mask & COREDUMP_WAIT) {
>   		switch (cn->core_type) {
>   		case COREDUMP_PIPE:
>   			wait_for_dump_helpers(cprm->file);
> diff --git a/include/linux/coredump.h b/include/linux/coredump.h
> index 7b38ee2e7913..dc7a05b1bb0a 100644
> --- a/include/linux/coredump.h
> +++ b/include/linux/coredump.h
> @@ -26,6 +26,8 @@ struct coredump_params {
>   	/* Snapshot of dumpable at dump start. */
>   	enum task_dumpable dumpable;
>   	int cpu;
> +	/* COREDUMP_* options negotiated with the coredump server. */
> +	u64 mask;
>   	loff_t written;
>   	loff_t pos;
>   	loff_t to_skip;
>
-- 
Thanks and Regards
R.Nageswara Sastry