mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Zhao, Yakui" <yakui.zhao@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
	Jason Chen CJ <jason.cj.chen@intel.com>
Subject: Re: [RFC PATCH v3 3/4] x86: Use HYPERVISOR_CALLBACK_VECTOR for acrn_guest upcall vector
Date: Fri, 12 Apr 2019 09:00:10 +0800	[thread overview]
Message-ID: <1aaea739-ded7-13da-c2d0-54423de0eab0@intel.com> (raw)
In-Reply-To: <20190411135547.GH30080@zn.tnic>



On 2019年04月11日 21:55, Borislav Petkov wrote:
> On Wed, Apr 10, 2019 at 03:57:08PM +0800, Zhao, Yakui wrote:
>> It is used to avoid that one function declaration has no definition
>> when asm/acrnhyper.h is included and ACRN_GUEST is not enabled.
> 
> And that is a problem because...?

This is not a problem.
I take a look at the header file of mshyperv.h and xen/events.h.
It seems that they have no such extra conditional definition.
To follow the same style, I will remove it.

> 
>> Do you have any suggestion about the header order?
>>>
>>> linux/ path includes still need to come first, of course.
> 
> As said above:
> 
> linux/ path first, then asm/
> 
> Feel free to look around the tree for inspiration :)

I take a look at the file of vwmare.c/mshyperv.c under the directory of 
arch/x86/kernel/cpu. It seems that the header file only follows the 
order of: linux/ path first and then asm/.

Anyway, I will follow your idea in previous email and use the alphabetic 
order.

Thanks
> 

  reply	other threads:[~2019-04-12  1:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08  8:12 [RFC PATCH v3 0/4] x86: Add the support of ACRN guest under arch/x86 Zhao Yakui
2019-04-08  8:12 ` [RFC PATCH v3 1/4] x86: Add new config symbol to unify conditional definition of hv_irq_callback_count Zhao Yakui
2019-04-08  9:35   ` Borislav Petkov
2019-04-10  7:06     ` Zhao, Yakui
2019-04-08  8:12 ` [RFC PATCH v3 2/4] x86: Add the support of ACRN guest Zhao Yakui
2019-04-08 14:39   ` Borislav Petkov
2019-04-10  9:15     ` Zhao, Yakui
2019-04-11 13:49       ` Borislav Petkov
2019-04-12  0:36         ` Zhao, Yakui
2019-04-12  8:24           ` Borislav Petkov
2019-04-08  8:12 ` [RFC PATCH v3 3/4] x86: Use HYPERVISOR_CALLBACK_VECTOR for acrn_guest upcall vector Zhao Yakui
2019-04-08 15:00   ` Borislav Petkov
2019-04-10  7:57     ` Zhao, Yakui
2019-04-11 13:55       ` Borislav Petkov
2019-04-12  1:00         ` Zhao, Yakui [this message]
2019-04-12  8:31           ` Borislav Petkov
2019-04-08  8:12 ` [RFC PATCH v3 4/4] x86: Add hypercall for acrn_guest Zhao Yakui
2019-04-08 15:10   ` Borislav Petkov
2019-04-10  8:17     ` Zhao, Yakui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1aaea739-ded7-13da-c2d0-54423de0eab0@intel.com \
    --to=yakui.zhao@intel.com \
    --cc=bp@alien8.de \
    --cc=jason.cj.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®