From: Borislav Petkov <bp@alien8.de>
To: Zhao Yakui <yakui.zhao@intel.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
Jason Chen CJ <jason.cj.chen@intel.com>
Subject: Re: [RFC PATCH v3 4/4] x86: Add hypercall for acrn_guest
Date: Mon, 8 Apr 2019 17:10:10 +0200 [thread overview]
Message-ID: <20190408151010.GI15689@zn.tnic> (raw)
In-Reply-To: <1554711131-21514-5-git-send-email-yakui.zhao@intel.com>
On Mon, Apr 08, 2019 at 04:12:11PM +0800, Zhao Yakui wrote:
> When acrn_hypervisor is detected, the hypercall is needed so that the
> acrn guest can query/config some settings. For example: it can be used
> to query the resources in hypervisor and manage the CPU/memory/device/
> interrupt for Guest system.
Good example.
What is "Guest system" and why is capitalized? Do you mean "the guest
operating system" or simply "the guest"?
> So the hypercall is added so that the kernel can communicate with the
"So add the hypercall so that... "
> low-level acrn-hypervisor.
Is it acrn_hypervisor or acrn-hypervisor or the ACRN hypervisor or ...?
Unify the naming pls.
> On x86 it is implemented by using vmacll when
During last review Thomas said:
"is implemented with the VMCALL instruction"
You still have it wrong. Which makes me think you haven't even gone over
*all* review comments as this is the second missed review comment in a
4-patches set.
So I'm going to stop reviewing here and won't look at your patches until
you incorporate *all* review comments from all people.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-04-08 15:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 8:12 [RFC PATCH v3 0/4] x86: Add the support of ACRN guest under arch/x86 Zhao Yakui
2019-04-08 8:12 ` [RFC PATCH v3 1/4] x86: Add new config symbol to unify conditional definition of hv_irq_callback_count Zhao Yakui
2019-04-08 9:35 ` Borislav Petkov
2019-04-10 7:06 ` Zhao, Yakui
2019-04-08 8:12 ` [RFC PATCH v3 2/4] x86: Add the support of ACRN guest Zhao Yakui
2019-04-08 14:39 ` Borislav Petkov
2019-04-10 9:15 ` Zhao, Yakui
2019-04-11 13:49 ` Borislav Petkov
2019-04-12 0:36 ` Zhao, Yakui
2019-04-12 8:24 ` Borislav Petkov
2019-04-08 8:12 ` [RFC PATCH v3 3/4] x86: Use HYPERVISOR_CALLBACK_VECTOR for acrn_guest upcall vector Zhao Yakui
2019-04-08 15:00 ` Borislav Petkov
2019-04-10 7:57 ` Zhao, Yakui
2019-04-11 13:55 ` Borislav Petkov
2019-04-12 1:00 ` Zhao, Yakui
2019-04-12 8:31 ` Borislav Petkov
2019-04-08 8:12 ` [RFC PATCH v3 4/4] x86: Add hypercall for acrn_guest Zhao Yakui
2019-04-08 15:10 ` Borislav Petkov [this message]
2019-04-10 8:17 ` Zhao, Yakui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408151010.GI15689@zn.tnic \
--to=bp@alien8.de \
--cc=jason.cj.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®