Re: [PATCH v2 1/3] x86/mce/inject: Remove call to mce_notify_irq()

[Nikolay Borisov <nik.borisov@suse.com>]

On 11.02.25 г. 9:03 ч., Zhuo, Qiuxu wrote:
>> From: Nikolay Borisov <nik.borisov@suse.com>
>> [...]
>> --- a/arch/x86/kernel/cpu/mce/core.c
>> +++ b/arch/x86/kernel/cpu/mce/core.c
>> @@ -584,6 +584,28 @@ bool mce_is_correctable(struct mce *m)  }
>> EXPORT_SYMBOL_GPL(mce_is_correctable);
>>
>> +/*
>> + * Notify the user(s) about new machine check events.
>> + * Can be called from interrupt context, but not from machine check/NMI
>> + * context.
>> + */
>> +static int mce_notify_irq(void)
> 
> Why make mce_notify_irq() return an int?


Pff... because I based my patches off master and not tip, which has it 
as bool...
> 
>> [...]
>> -/*
>> - * Notify the user(s) about new machine check events.
>> - * Can be called from interrupt context, but not from machine check/NMI
>> - * context.
>> - */
>> -bool mce_notify_irq(void)
>> [...]