mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nikolay Borisov <nik.borisov@suse.com>
To: linux-edac@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	tony.luck@intel.com, Nikolay Borisov <nik.borisov@suse.com>
Subject: [PATCH v2 3/3] x86/mce: Make mce_notify_irq() depend on CONFIG_X86_MCELOG_LEGACY
Date: Mon, 10 Feb 2025 17:47:06 +0200	[thread overview]
Message-ID: <20250210154707.114219-4-nik.borisov@suse.com> (raw)
In-Reply-To: <20250210154707.114219-1-nik.borisov@suse.com>

mce_notify_irq() really depends on the legacy mcelog being enabled as
otherwise mce_work_trigger() will never schedule the trigger work as
mce_helper can't be set unless CONFIG_X86_MCELOG_LEGACY is defined.

Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
---
 arch/x86/kernel/cpu/mce/core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index d55b1903fde6..8b8553e144ce 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -591,11 +591,13 @@ EXPORT_SYMBOL_GPL(mce_is_correctable);
  */
 static int mce_notify_irq(void)
 {
+#ifdef CONFIG_X86_MCELOG_LEGACY
+
 	if (test_and_clear_bit(0, &mce_need_notify)) {
 		mce_work_trigger();
 		return 1;
 	}
-
+#endif
 	return 0;
 }
 
-- 
2.43.0


  parent reply	other threads:[~2025-02-10 15:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10 15:47 [PATCH v2 0/3] Simpify mce code somewhat Nikolay Borisov
2025-02-10 15:47 ` [PATCH v2 1/3] x86/mce/inject: Remove call to mce_notify_irq() Nikolay Borisov
2025-02-11  7:03   ` Zhuo, Qiuxu
2025-02-11  8:49     ` Nikolay Borisov
2025-02-11 12:37       ` Zhuo, Qiuxu
2025-02-16 16:10   ` Borislav Petkov
2025-02-17 10:01     ` Nikolay Borisov
2025-02-17 11:20       ` Nikolay Borisov
2025-02-17 11:47         ` Borislav Petkov
2025-02-10 15:47 ` [PATCH v2 2/3] x86/mce: Move message printing from mce_notify_irq to mce_early_notifier() Nikolay Borisov
2025-02-11  7:10   ` Zhuo, Qiuxu
2025-02-25 13:10   ` Borislav Petkov
2025-02-10 15:47 ` Nikolay Borisov [this message]
2025-02-11  7:20   ` [PATCH v2 3/3] x86/mce: Make mce_notify_irq() depend on CONFIG_X86_MCELOG_LEGACY Zhuo, Qiuxu
2025-02-11 10:18     ` Nikolay Borisov
2025-02-25 13:12   ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250210154707.114219-4-nik.borisov@suse.com \
    --to=nik.borisov@suse.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®