mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sridharan S N <quic_sridsn@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
	<andersson@kernel.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on IPQ9574 family
Date: Thu, 3 Aug 2023 16:41:44 +0530	[thread overview]
Message-ID: <1ac4ec1d-f01e-6ddd-708d-6dec7ca4ea3d@quicinc.com> (raw)
In-Reply-To: <b57e0199-141f-2a37-4d5a-b98da5276b89@linaro.org>


On 7/26/2023 12:51 PM, Krzysztof Kozlowski wrote:
> On 26/07/2023 07:03, Sridharan S N wrote:
>> On 7/20/2023 3:18 PM, Konrad Dybcio wrote:
>>> On 20.07.2023 10:49, Krzysztof Kozlowski wrote:
>>>> On 20/07/2023 10:45, Sridharan S N wrote:
>>>>> Document the below listed (Reference Design Platform) RDP boards based on IPQ9574
>>>>> family of SoCs.
>>>>>
>>>>> AL02-C3  - rdp437
>>>>> AL02-C7  - rdp433-mht-phy
>>>>> AL02-C10 - rdp433-mht-switch
>>>>> AL02-C11 - rdp467
>>>>> AL02-C12 - rdp455
>>>>> AL02-C13 - rdp459
>>>>> AL02-C15 - rdp457
>>>>> AL02-C16 - rdp456
>>>>> AL02-C17 - rdp469
>>>>> AL02-C19 - rdp461
>>>>> AL03-C2  - rdp458
>>>>>
>>>>> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
>>>>> ---
>>>>>    .../devicetree/bindings/arm/qcom.yaml         | 20 +++++++++++++++++++
>>>>>    1 file changed, 20 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>> index dd66fd872c31..d992261da691 100644
>>>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>> @@ -89,10 +89,20 @@ description: |
>>>>>            adp
>>>>>            ap-al01-c1
>>>>>            ap-al02-c2
>>>>> +        ap-al02-c3
>>>>>            ap-al02-c6
>>>>>            ap-al02-c7
>>>>>            ap-al02-c8
>>>>>            ap-al02-c9
>>>>> +        ap-al02-c10
>>>>> +        ap-al02-c11
>>>>> +        ap-al02-c12
>>>>> +        ap-al02-c13
>>>>> +        ap-al02-c15
>>>>> +        ap-al02-c16
>>>>> +        ap-al02-c17
>>>>> +        ap-al02-c19
>>>> Why? I asked once, but there was no feedback from Qualcomm.
>>>>
>>>> Why do we need to do this? What's the point?
>>> Another question would be, whether these boards are just one-off test
>>> prototypes of which there exist like 5-10 units, or are they actually
>>> going to be supported and useful.
>>>
>>> If it's the former, I don't think it makes sense to keep the device
>>> trees upstream.
>>>
>>> Konrad
>> These are all not test rdps and each rdps has its own configurations.
>> IPQ9574 has four pcie instances and one QDSP processor. Not all rdps use
>> all of the interfaces and it will vary for each rdp. In next version ,
>> will post with each rdp's configuration explicitly
>
> So still no answer why do we need to list it as possible boards.
> Especially that it messes with compatible style, because c[1-9] looks
> like board version.
>
> I suggest don't add these board types and drop existing ones.
>
>
> Best regards,
> Krzysztof

Apologize for the late reply. IPQ bootloader doesn't need these info. we 
will send the patch to drop the existing ones

Thanks,

Sridharan


  reply	other threads:[~2023-08-03 11:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20  8:45 [PATCH 0/2] Add initial support for various RDPs of " Sridharan S N
2023-07-20  8:45 ` [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on " Sridharan S N
2023-07-20  8:49   ` Krzysztof Kozlowski
2023-07-20  9:48     ` Konrad Dybcio
2023-07-26  5:03       ` Sridharan S N
2023-07-26  7:21         ` Krzysztof Kozlowski
2023-08-03 11:11           ` Sridharan S N [this message]
2023-07-20  8:45 ` [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for various RDPs Sridharan S N
2023-07-20  8:51   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ac4ec1d-f01e-6ddd-708d-6dec7ca4ea3d@quicinc.com \
    --to=quic_sridsn@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®