From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sridharan S N <quic_sridsn@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for various RDPs
Date: Thu, 20 Jul 2023 10:51:22 +0200 [thread overview]
Message-ID: <fb07d227-f786-c7a2-5295-2254495e4a5a@linaro.org> (raw)
In-Reply-To: <20230720084534.6461-3-quic_sridsn@quicinc.com>
On 20/07/2023 10:45, Sridharan S N wrote:
> Add the initial device tree support for the Reference Design
> Platform(RDPs) 433-mht-phy,433-mht-switch,437,455,456,457,458,459
> 461,467,469 based on IPQ9574 family of SoC.
>
> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
> ---
...
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp456.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp456.dts
> new file mode 100644
> index 000000000000..22d69ec8912f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp456.dts
> @@ -0,0 +1,16 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +/*
> + * IPQ9574 RDP456 board device tree source
> + *
> + * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
> + * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +/dts-v1/;
> +
> +#include "ipq9574-rdp-common.dtsi"
> +
> +/ {
> + model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL02-C16";
> + compatible = "qcom,ipq9574-ap-al02-c16", "qcom,ipq9574";
I am sorry folks, but what are you doing here? Why are you adding all
these DTSes? What is the point? They are all the same. Where is the
product datasheet or description so we can validate it?
Best regards,
Krzysztof
prev parent reply other threads:[~2023-07-20 8:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 8:45 [PATCH 0/2] Add initial support for various RDPs of IPQ9574 family Sridharan S N
2023-07-20 8:45 ` [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on " Sridharan S N
2023-07-20 8:49 ` Krzysztof Kozlowski
2023-07-20 9:48 ` Konrad Dybcio
2023-07-26 5:03 ` Sridharan S N
2023-07-26 7:21 ` Krzysztof Kozlowski
2023-08-03 11:11 ` Sridharan S N
2023-07-20 8:45 ` [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for various RDPs Sridharan S N
2023-07-20 8:51 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb07d227-f786-c7a2-5295-2254495e4a5a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_sridsn@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®