From: Antonio Borneo <antonio.borneo@foss.st.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
<linux-kernel@vger.kernel.org>
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
<devicetree@vger.kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
<linux-amarula@amarulasolutions.com>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [Linux-stm32] [PATCH] ARM: dts: stm32: use IRQ_TYPE_EDGE_FALLING on stm32mp157c-dk2
Date: Sat, 1 Mar 2025 13:45:08 +0100 [thread overview]
Message-ID: <1ae59b115cb2e4570c6e77a01bcdac11dff03ae1.camel@foss.st.com> (raw)
In-Reply-To: <20250301115116.2862353-1-dario.binacchi@amarulasolutions.com>
On Sat, 2025-03-01 at 12:51 +0100, Dario Binacchi wrote:
> Replace the number 2 with the appropriate numerical constant defined in
> dt-bindings/interrupt-controller/irq.h.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>
> ---
>
> arch/arm/boot/dts/st/stm32mp157c-dk2.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> index 5f9c0160a9c4..dcf17c493022 100644
> --- a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> +++ b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> @@ -11,6 +11,7 @@
> #include "stm32mp15-pinctrl.dtsi"
> #include "stm32mp15xxac-pinctrl.dtsi"
> #include "stm32mp15xx-dkx.dtsi"
> +#include <dt-bindings/interrupt-controller/irq.h>
>
> / {
> model = "STMicroelectronics STM32MP157C-DK2 Discovery Board";
> @@ -67,7 +68,7 @@ &i2c1 {
> touchscreen@38 {
> compatible = "focaltech,ft6236";
> reg = <0x38>;
> - interrupts = <2 2>;
> + interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
> interrupt-parent = <&gpiof>;
> touchscreen-size-x = <480>;
> touchscreen-size-y = <800>;
Thanks!
Reviewed-by: Antonio Borneo <antonio.borneo@foss.st.com>
next prev parent reply other threads:[~2025-03-01 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 11:51 Dario Binacchi
2025-03-01 12:45 ` Antonio Borneo [this message]
2025-03-10 10:48 ` Alexandre TORGUE
2025-03-10 12:24 ` Dario Binacchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ae59b115cb2e4570c6e77a01bcdac11dff03ae1.camel@foss.st.com \
--to=antonio.borneo@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®