* [PATCH] ARM: dts: stm32: use IRQ_TYPE_EDGE_FALLING on stm32mp157c-dk2
@ 2025-03-01 11:51 Dario Binacchi
2025-03-01 12:45 ` [Linux-stm32] " Antonio Borneo
2025-03-10 10:48 ` Alexandre TORGUE
0 siblings, 2 replies; 4+ messages in thread
From: Dario Binacchi @ 2025-03-01 11:51 UTC (permalink / raw)
To: linux-kernel
Cc: linux-amarula, Dario Binacchi, Alexandre Torgue, Conor Dooley,
Krzysztof Kozlowski, Maxime Coquelin, Rob Herring, devicetree,
linux-arm-kernel, linux-stm32
Replace the number 2 with the appropriate numerical constant defined in
dt-bindings/interrupt-controller/irq.h.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
arch/arm/boot/dts/st/stm32mp157c-dk2.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
index 5f9c0160a9c4..dcf17c493022 100644
--- a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
+++ b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
@@ -11,6 +11,7 @@
#include "stm32mp15-pinctrl.dtsi"
#include "stm32mp15xxac-pinctrl.dtsi"
#include "stm32mp15xx-dkx.dtsi"
+#include <dt-bindings/interrupt-controller/irq.h>
/ {
model = "STMicroelectronics STM32MP157C-DK2 Discovery Board";
@@ -67,7 +68,7 @@ &i2c1 {
touchscreen@38 {
compatible = "focaltech,ft6236";
reg = <0x38>;
- interrupts = <2 2>;
+ interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
interrupt-parent = <&gpiof>;
touchscreen-size-x = <480>;
touchscreen-size-y = <800>;
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Linux-stm32] [PATCH] ARM: dts: stm32: use IRQ_TYPE_EDGE_FALLING on stm32mp157c-dk2
2025-03-01 11:51 [PATCH] ARM: dts: stm32: use IRQ_TYPE_EDGE_FALLING on stm32mp157c-dk2 Dario Binacchi
@ 2025-03-01 12:45 ` Antonio Borneo
2025-03-10 10:48 ` Alexandre TORGUE
1 sibling, 0 replies; 4+ messages in thread
From: Antonio Borneo @ 2025-03-01 12:45 UTC (permalink / raw)
To: Dario Binacchi, linux-kernel
Cc: Rob Herring, Conor Dooley, devicetree, Maxime Coquelin,
Krzysztof Kozlowski, linux-amarula, linux-stm32,
linux-arm-kernel
On Sat, 2025-03-01 at 12:51 +0100, Dario Binacchi wrote:
> Replace the number 2 with the appropriate numerical constant defined in
> dt-bindings/interrupt-controller/irq.h.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>
> ---
>
> arch/arm/boot/dts/st/stm32mp157c-dk2.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> index 5f9c0160a9c4..dcf17c493022 100644
> --- a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> +++ b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> @@ -11,6 +11,7 @@
> #include "stm32mp15-pinctrl.dtsi"
> #include "stm32mp15xxac-pinctrl.dtsi"
> #include "stm32mp15xx-dkx.dtsi"
> +#include <dt-bindings/interrupt-controller/irq.h>
>
> / {
> model = "STMicroelectronics STM32MP157C-DK2 Discovery Board";
> @@ -67,7 +68,7 @@ &i2c1 {
> touchscreen@38 {
> compatible = "focaltech,ft6236";
> reg = <0x38>;
> - interrupts = <2 2>;
> + interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
> interrupt-parent = <&gpiof>;
> touchscreen-size-x = <480>;
> touchscreen-size-y = <800>;
Thanks!
Reviewed-by: Antonio Borneo <antonio.borneo@foss.st.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: stm32: use IRQ_TYPE_EDGE_FALLING on stm32mp157c-dk2
2025-03-01 11:51 [PATCH] ARM: dts: stm32: use IRQ_TYPE_EDGE_FALLING on stm32mp157c-dk2 Dario Binacchi
2025-03-01 12:45 ` [Linux-stm32] " Antonio Borneo
@ 2025-03-10 10:48 ` Alexandre TORGUE
2025-03-10 12:24 ` Dario Binacchi
1 sibling, 1 reply; 4+ messages in thread
From: Alexandre TORGUE @ 2025-03-10 10:48 UTC (permalink / raw)
To: Dario Binacchi, linux-kernel
Cc: linux-amarula, Conor Dooley, Krzysztof Kozlowski,
Maxime Coquelin, Rob Herring, devicetree, linux-arm-kernel,
linux-stm32
Hi Dario
On 3/1/25 12:51, Dario Binacchi wrote:
> Replace the number 2 with the appropriate numerical constant defined in
> dt-bindings/interrupt-controller/irq.h.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>
> ---
>
> arch/arm/boot/dts/st/stm32mp157c-dk2.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> index 5f9c0160a9c4..dcf17c493022 100644
> --- a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> +++ b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> @@ -11,6 +11,7 @@
> #include "stm32mp15-pinctrl.dtsi"
> #include "stm32mp15xxac-pinctrl.dtsi"
> #include "stm32mp15xx-dkx.dtsi"
> +#include <dt-bindings/interrupt-controller/irq.h>
really needed ? as it comes also with
dt-bindings/interrupt-controller/arm-gic.h
> / {
> model = "STMicroelectronics STM32MP157C-DK2 Discovery Board";
> @@ -67,7 +68,7 @@ &i2c1 {
> touchscreen@38 {
> compatible = "focaltech,ft6236";
> reg = <0x38>;
> - interrupts = <2 2>;
> + interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
> interrupt-parent = <&gpiof>;
> touchscreen-size-x = <480>;
> touchscreen-size-y = <800>;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: stm32: use IRQ_TYPE_EDGE_FALLING on stm32mp157c-dk2
2025-03-10 10:48 ` Alexandre TORGUE
@ 2025-03-10 12:24 ` Dario Binacchi
0 siblings, 0 replies; 4+ messages in thread
From: Dario Binacchi @ 2025-03-10 12:24 UTC (permalink / raw)
To: Alexandre TORGUE
Cc: linux-kernel, linux-amarula, Conor Dooley, Krzysztof Kozlowski,
Maxime Coquelin, Rob Herring, devicetree, linux-arm-kernel,
linux-stm32
Hi Alexandre,
On Mon, Mar 10, 2025 at 11:50 AM Alexandre TORGUE
<alexandre.torgue@foss.st.com> wrote:
>
> Hi Dario
>
> On 3/1/25 12:51, Dario Binacchi wrote:
> > Replace the number 2 with the appropriate numerical constant defined in
> > dt-bindings/interrupt-controller/irq.h.
> >
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> >
> > ---
> >
> > arch/arm/boot/dts/st/stm32mp157c-dk2.dts | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> > index 5f9c0160a9c4..dcf17c493022 100644
> > --- a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> > +++ b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> > @@ -11,6 +11,7 @@
> > #include "stm32mp15-pinctrl.dtsi"
> > #include "stm32mp15xxac-pinctrl.dtsi"
> > #include "stm32mp15xx-dkx.dtsi"
> > +#include <dt-bindings/interrupt-controller/irq.h>
>
> really needed ? as it comes also with
> dt-bindings/interrupt-controller/arm-gic.h
yes, you are right:
stm32mp157c-dk2.dts
--> stm32mp157.dtsi
--> stm32mp153.dtsi
--> stm32mp151.dtsi
#include <dt-bindings/interrupt-controller/arm-gic.h>
I'll submit v2.
Thanks and regards
Dario
>
> > / {
> > model = "STMicroelectronics STM32MP157C-DK2 Discovery Board";
> > @@ -67,7 +68,7 @@ &i2c1 {
> > touchscreen@38 {
> > compatible = "focaltech,ft6236";
> > reg = <0x38>;
> > - interrupts = <2 2>;
> > + interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
> > interrupt-parent = <&gpiof>;
> > touchscreen-size-x = <480>;
> > touchscreen-size-y = <800>;
--
Dario Binacchi
Senior Embedded Linux Developer
dario.binacchi@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-10 12:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-01 11:51 [PATCH] ARM: dts: stm32: use IRQ_TYPE_EDGE_FALLING on stm32mp157c-dk2 Dario Binacchi
2025-03-01 12:45 ` [Linux-stm32] " Antonio Borneo
2025-03-10 10:48 ` Alexandre TORGUE
2025-03-10 12:24 ` Dario Binacchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®