From: "qinjian[覃健]" <qinjian@cqplus1.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
"Russell King - ARM Linux" <linux@armlinux.org.uk>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>
Subject: RE: [PATCH v12 5/9] clk: Add Sunplus SP7021 clock driver
Date: Sat, 2 Apr 2022 03:37:22 +0000 [thread overview]
Message-ID: <1af581687f424316b8759c65997694db@cqplus1.com> (raw)
In-Reply-To: <CAK8P3a002iHquY4J59omBwxyZjCFFiymqbWKu9GXs-7RVy292g@mail.gmail.com>
>
> > > > + /* This memory region include multi HW regs in discontinuous order.
> > > > + * clk driver used some discontinuous areas in the memory region.
> > > > + * Using devm_platform_ioremap_resource() would conflicted with other drivers.
> > > > + */
> > > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > > + sp_clk_base = devm_ioremap(dev, res->start, resource_size(res));
> > > > + if (!sp_clk_base)
> > > > + return -ENXIO;
> > >
> > > Can you explain this comment in more detail? Generally, the 'reg' properties
> > > of drivers should not overlap, so it is supposed to be safe to call
> > > devm_platform_ioremap_resource() here.
> > >
> > > We discussed this in the context of the iop driver that did have overlapping
> > > registers with this driver, and that was incorrect. Are there any other drivers
> > > that conflict with the clk driver?
> >
> > I means, I must split up the origin reg region into 4 small pieces,
> > and call devm_platform_ioremap_resource() 4 times.
> > Did I should follow this way?
>
> It depends. What are those other registers, and what drivers use them?
>
> Arnd
Include Reset / PinMux / USBC / UPHY regs, which used by related drivers.
next prev parent reply other threads:[~2022-04-02 3:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 8:29 [PATCH v12 0/9] Add Sunplus SP7021 SoC Support Qin Jian
2022-03-31 8:29 ` [PATCH v12 1/9] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards Qin Jian
2022-03-31 8:29 ` [PATCH v12 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver Qin Jian
2022-03-31 8:58 ` Arnd Bergmann
2022-04-01 8:24 ` qinjian[覃健]
2022-03-31 8:29 ` [PATCH v12 3/9] reset: Add Sunplus " Qin Jian
2022-03-31 8:59 ` Arnd Bergmann
2022-03-31 8:29 ` [PATCH v12 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Qin Jian
2022-03-31 20:21 ` Krzysztof Kozlowski
2022-04-01 9:19 ` qinjian[覃健]
2022-04-01 9:32 ` Krzysztof Kozlowski
2022-03-31 8:29 ` [PATCH v12 5/9] clk: Add Sunplus " Qin Jian
2022-03-31 9:22 ` Arnd Bergmann
2022-04-01 9:47 ` qinjian[覃健]
2022-04-01 10:09 ` Arnd Bergmann
2022-04-02 3:37 ` qinjian[覃健] [this message]
2022-03-31 8:29 ` [PATCH v12 6/9] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller Qin Jian
2022-03-31 20:44 ` Rob Herring
2022-04-01 2:29 ` qinjian[覃健]
2022-04-01 17:53 ` Rob Herring
2022-04-02 2:43 ` qinjian[覃健]
2022-03-31 8:29 ` [PATCH v12 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver Qin Jian
2022-03-31 9:17 ` Arnd Bergmann
2022-04-01 7:17 ` qinjian[覃健]
2022-03-31 8:29 ` [PATCH v12 8/9] ARM: sunplus: Add initial support for Sunplus SP7021 SoC Qin Jian
2022-03-31 9:03 ` Arnd Bergmann
2022-03-31 8:29 ` [PATCH v12 9/9] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig Qin Jian
2022-03-31 9:09 ` Arnd Bergmann
2022-04-01 7:08 ` qinjian[覃健]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1af581687f424316b8759c65997694db@cqplus1.com \
--to=qinjian@cqplus1.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®