From: Damien Le Moal <dlemoal@kernel.org>
To: Wilfred Mallawa <wilfred.opensource@gmail.com>,
James Smart <james.smart@broadcom.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Wilfred Mallawa <wilfred.mallawa@wdc.com>
Subject: Re: [PATCH 2/2] nvme/host: fixup some typos
Date: Wed, 17 Dec 2025 10:42:38 +0900 [thread overview]
Message-ID: <1afe4a52-2c61-4441-8e6c-5cee343d7419@kernel.org> (raw)
In-Reply-To: <20251216032931.1305349-4-wilfred.opensource@gmail.com>
On 12/16/25 12:29, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Looks good, but write something as the commit message.
One nit below.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> @@ -271,7 +271,7 @@ static bool nvme_validate_passthru_nsid(struct nvme_ctrl *ctrl,
> {
> if (ns && nsid != ns->head->ns_id) {
> dev_err(ctrl->device,
> - "%s: nsid (%u) in cmd does not match nsid (%u)"
> + "%s: nsid (%u) in cmd does not match nsid (%u) "
> "of namespace\n",
I know that Christoph does not like long lines, but it may be better to unwrap
this message to make it easier to grep the code.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-12-17 1:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 3:29 [PATCH 1/2] nvmem/core: fixup minor typo Wilfred Mallawa
2025-12-16 3:29 ` [PATCH 2/2] nvme/host: fixup some typos Wilfred Mallawa
2025-12-17 1:42 ` Damien Le Moal [this message]
2025-12-17 1:39 ` [PATCH 1/2] nvmem/core: fixup minor typo Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1afe4a52-2c61-4441-8e6c-5cee343d7419@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=srinivas.kandagatla@linaro.org \
--cc=wilfred.mallawa@wdc.com \
--cc=wilfred.opensource@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome