mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] .gitignore: ignore GNUmakefile
@ 2026-10-27 10:11 Qu Wenruo
  2026-10-27 11:48 ` Daniel Vacek
  0 siblings, 1 reply; 2+ messages in thread
From: Qu Wenruo @ 2026-10-27 10:11 UTC (permalink / raw)
  To: linux-btrfs, linux-kernel, llvm

I use GNUmakefile to shorten the command of "make".

E.g. for my arm64 worktree, I have a GNUmakefile with:

 export ARCH := arm64
 export LLVM := 1
 export PACMAN_PKGBASE := linux-arm64-custom
 export PACMAN_EXTRAPACKAGES :=
 export PKGEXT := .pkg.tar
 MAKEFLAGS += -j12
 include Makefile

And for my x86_64 worktree, it looks a little simpler:

 export LLVM := 1
 export PACMAN_PKGBASE := linux-custom
 export PACMAN_EXTRAPACKAGES :=
 export PKGEXT := pkg.tar
 MAKEFLAGS += -j12
 include Makefile

So at least in my case, GNUmakefile is really a shortcut to specify
extra environment variables and build flags.
Thus it should be added to gitignore.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
Changelog:
v2:
- Limit the GNUmakefile to the top-level directory
---
 .gitignore | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.gitignore b/.gitignore
index 9875120ea7bd..6f018294a119 100644
--- a/.gitignore
+++ b/.gitignore
@@ -194,3 +194,6 @@ sphinx_*/
 
 # bc language scripts (not LLVM bitcode)
 !kernel/time/timeconst.bc
+
+# GNUmakefile, mostly to export extra env variables or build flags
+/GNUmakefile
-- 
2.56.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] .gitignore: ignore GNUmakefile
  2026-10-27 10:11 [PATCH v2] .gitignore: ignore GNUmakefile Qu Wenruo
@ 2026-10-27 11:48 ` Daniel Vacek
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vacek @ 2026-10-27 11:48 UTC (permalink / raw)
  To: Qu Wenruo; +Cc: linux-btrfs, linux-kernel, llvm

On Tue, 27 Oct 2026 at 11:15, Qu Wenruo <wqu@suse.com> wrote:
> I use GNUmakefile to shorten the command of "make".
>
> E.g. for my arm64 worktree, I have a GNUmakefile with:
>
>  export ARCH := arm64
>  export LLVM := 1
>  export PACMAN_PKGBASE := linux-arm64-custom
>  export PACMAN_EXTRAPACKAGES :=
>  export PKGEXT := .pkg.tar
>  MAKEFLAGS += -j12
>  include Makefile
>
> And for my x86_64 worktree, it looks a little simpler:
>
>  export LLVM := 1
>  export PACMAN_PKGBASE := linux-custom
>  export PACMAN_EXTRAPACKAGES :=
>  export PKGEXT := pkg.tar
>  MAKEFLAGS += -j12
>  include Makefile
>
> So at least in my case, GNUmakefile is really a shortcut to specify
> extra environment variables and build flags.
> Thus it should be added to gitignore.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>

LGTM.

Reviewed-by: Daniel Vacek <neelx@suse.com>

Thanks

> ---
> Changelog:
> v2:
> - Limit the GNUmakefile to the top-level directory
> ---
>  .gitignore | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 9875120ea7bd..6f018294a119 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -194,3 +194,6 @@ sphinx_*/
>
>  # bc language scripts (not LLVM bitcode)
>  !kernel/time/timeconst.bc
> +
> +# GNUmakefile, mostly to export extra env variables or build flags
> +/GNUmakefile
> --
> 2.56.0
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-27 11:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-27 10:11 [PATCH v2] .gitignore: ignore GNUmakefile Qu Wenruo
2026-10-27 11:48 ` Daniel Vacek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®