From: boris.ostrovsky@oracle.com
To: Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
xen-devel@lists.xenproject.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] xen: fix multicall debug data referencing
Date: Thu, 18 Jul 2024 17:56:49 -0400 [thread overview]
Message-ID: <1b3e9102-7d1f-43df-b6a0-9da84bc9ec12@oracle.com> (raw)
In-Reply-To: <20240718062100.5357-1-jgross@suse.com>
On 7/18/24 2:21 AM, Juergen Gross wrote:
> The recent adding of multicall debug mixed up the referencing of
> the debug data. A __percpu tagged pointer can't be initialized with a
> plain pointer, so use another percpu variable for the pointer and set
> it on each new cpu via a function.
>
> Fixes: 942d917cb92a ("xen: make multicall debug boot time selectable")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202407151106.5s7Mnfpz-lkp@intel.com/
> Signed-off-by: Juergen Gross <jgross@suse.com>
IIUIC we only need data until SMP is initialized, so setting per-cpu
pointer just on cpu0 may be sufficient. Not sure where to do this though.
But this works as well.
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
prev parent reply other threads:[~2024-07-18 21:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 6:21 Juergen Gross
2024-07-18 21:56 ` boris.ostrovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b3e9102-7d1f-43df-b6a0-9da84bc9ec12@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®