From: Waiman Long <longman@redhat.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH-tip 2/3] locking/rwsem: move down rwsem_down_read_failed()
Date: Mon, 27 Feb 2017 09:22:35 -0500 [thread overview]
Message-ID: <1b64e661-4f95-9dcf-058b-0cebbcfa7294@redhat.com> (raw)
In-Reply-To: <20170226183341.GD5126@linux-80c1.suse>
On 02/26/2017 01:33 PM, Davidlohr Bueso wrote:
> On Wed, 22 Feb 2017, Waiman Long wrote:
>
>> Move the rwsem_down_read_failed() function down to below the
>> optimistic spinning section as it is going to use function in that
>> section in a later patch.
>
> So the title is a bit ambiguous, and I would argue that this
> should be folded into patch 3, and just mention it in the
> changelog.
>
> Thanks,
> Davidlohr
I can reword the title to clarify it a bit more.
The reason why it is a separate patch is because it will make it much
harder to review the third patch otherwise. What you get from the diff
will be a total replacement of one function block by another function
block. I would like to make the review focus on what is actually being
changed.
Cheers,
Longman
next prev parent reply other threads:[~2017-02-27 14:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 18:03 [PATCH-tip 0/3] locking/rwsem: Minor twists to improve rwsem performance Waiman Long
2017-02-22 18:03 ` [PATCH-tip 1/3] locking/rwsem: Check wait_list without lock if spinner present Waiman Long
2017-02-26 18:49 ` Davidlohr Bueso
2017-02-27 15:02 ` Waiman Long
2017-02-22 18:03 ` [PATCH-tip 2/3] locking/rwsem: move down rwsem_down_read_failed() Waiman Long
2017-02-26 18:33 ` Davidlohr Bueso
2017-02-27 14:22 ` Waiman Long [this message]
2017-02-22 18:03 ` [PATCH-tip 3/3] locking/rwsem: Stop active read lock ASAP Waiman Long
2017-02-26 18:58 ` Davidlohr Bueso
2017-02-27 15:07 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b64e661-4f95-9dcf-058b-0cebbcfa7294@redhat.com \
--to=longman@redhat.com \
--cc=dave@stgolabs.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®