From: ChenXiaoSong <chenxiaosong@chenxiaosong.com>
To: Daijiamu <3058704216@qq.com>,
linkinjeon@kernel.org, sergey.senozhatsky@gmail.com,
tom@talpey.com
Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ksmbd: use clear_and_wake_up_bit() in wake_up_oplock_break()
Date: Thu, 1 Oct 2026 10:51:21 +0800 [thread overview]
Message-ID: <1b73e6c1-5e35-4e03-8310-892efdfd77e5@chenxiaosong.com> (raw)
In-Reply-To: <tencent_238A42C6350C25F55AFAA340BCE35A0D3B08@qq.com>
We can remove wake_up_oplock_break() now as well, call
clear_and_wake_up_bit() directly.
On 10/1/26 02:37, Daijiamu wrote:
> static void wake_up_oplock_break(struct oplock_info *opinfo)
> {
> - clear_bit_unlock(0, &opinfo->pending_break);
> - /* memory barrier is needed for wake_up_bit() */
> - smp_mb__after_atomic();
> - wake_up_bit(&opinfo->pending_break, 0);
> + clear_and_wake_up_bit(0, &opinfo->pending_break);
> }
--
ChenXiaoSong <chenxiaosong@chenxiaosong.com>
Chinese Homepage: https://chenxiaosong.com
English Homepage: https://chenxiaosong.com/en
prev parent reply other threads:[~2026-10-01 2:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 18:37 Daijiamu
2026-10-01 2:51 ` ChenXiaoSong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b73e6c1-5e35-4e03-8310-892efdfd77e5@chenxiaosong.com \
--to=chenxiaosong@chenxiaosong.com \
--cc=3058704216@qq.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®