mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daijiamu <3058704216@qq.com>
To: linkinjeon@kernel.org, sergey.senozhatsky@gmail.com, tom@talpey.com
Cc: chenxiaosong@chenxiaosong.com, linux-cifs@vger.kernel.org,
	linux-kernel@vger.kernel.org, Daijiamu <3058704216@qq.com>
Subject: [PATCH] ksmbd: use clear_and_wake_up_bit() in wake_up_oplock_break()
Date: Thu,  1 Oct 2026 02:37:58 +0800	[thread overview]
Message-ID: <tencent_238A42C6350C25F55AFAA340BCE35A0D3B08@qq.com> (raw)

clear_and_wake_up_bit() was introduced by commit 8236b0ae31c8 ("bdi:
wake up concurrent wb_shutdown() callers.") to replace the open-coded
clear_bit_unlock() + smp_mb__after_atomic() + wake_up_bit() sequence.

Use the helper in wake_up_oplock_break() to standardize the code path.

Signed-off-by: Daijiamu <3058704216@qq.com>
---
 fs/smb/server/oplock.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/smb/server/oplock.c b/fs/smb/server/oplock.c
index 1b8c3482d1e4..bbf84b05dcf7 100644
--- a/fs/smb/server/oplock.c
+++ b/fs/smb/server/oplock.c
@@ -765,10 +765,7 @@ static bool wait_for_break_ack(struct oplock_info *opinfo)
 
 static void wake_up_oplock_break(struct oplock_info *opinfo)
 {
-	clear_bit_unlock(0, &opinfo->pending_break);
-	/* memory barrier is needed for wake_up_bit() */
-	smp_mb__after_atomic();
-	wake_up_bit(&opinfo->pending_break, 0);
+	clear_and_wake_up_bit(0, &opinfo->pending_break);
 }
 
 static bool oplock_break_set_ack_wait(struct oplock_info *opinfo)
-- 
2.55.0


             reply	other threads:[~2026-09-30 18:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30 18:37 Daijiamu [this message]
2026-10-01  2:51 ` ChenXiaoSong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_238A42C6350C25F55AFAA340BCE35A0D3B08@qq.com \
    --to=3058704216@qq.com \
    --cc=chenxiaosong@chenxiaosong.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®