From: Zijun Hu <zijun_hu@icloud.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, Zijun Hu <quic_zijuhu@quicinc.com>
Subject: Re: [PATCH 3/3] driver core: bus: Correct API bus_rescan_devices() behavior
Date: Wed, 4 Sep 2024 22:26:39 +0800 [thread overview]
Message-ID: <1b79fb55-26d7-4966-9260-d3cdf3e0e8c8@icloud.com> (raw)
In-Reply-To: <2024090403-viewing-snagged-4249@gregkh>
On 2024/9/4 21:54, Greg Kroah-Hartman wrote:
> On Wed, Sep 04, 2024 at 08:56:44PM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@quicinc.com>
>>
>> API bus_rescan_devices() should ideally scan drivers for a bus's devices
>> as many as possible, but it really stops scanning for remaining devices
>> even if a device encounters inconsequential errors such as -EPROBE_DEFER
>
> -EPROBE_DEFER should not be an issue for scanning the bus, that's only
> for probe errors, so who is returning that mess today? Let's fix that
> up please.
>
drivers/amba/bus.c:
struct bus_type amba_bustype = {
...
.match = amba_match,
...
};
amba_match() may return -EPROBE_DEFER.
you maybe also look at below AMBA bus related commit.
Commit: 656b8035b0ee ("ARM: 8524/1: driver cohandle -EPROBE_DEFER from
bus_type.match()"
is it proper to change bus_type match()'s return value type to bool type
back if this issue is fixed?
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2024-09-04 14:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 12:56 [PATCH 0/3] driver core: bus: Fix issues related to bus_rescan_devices_helper() Zijun Hu
2024-09-04 12:56 ` [PATCH 1/3] driver core: Mark impossible return values of bus_type's match() with unlikely() Zijun Hu
2024-09-04 13:53 ` Greg Kroah-Hartman
2024-09-04 15:45 ` Zijun Hu
2024-09-04 12:56 ` [PATCH 2/3] driver core: bus: Give error prompt for storing bus attribute drivers_probe failure Zijun Hu
2024-09-04 12:56 ` [PATCH 3/3] driver core: bus: Correct API bus_rescan_devices() behavior Zijun Hu
2024-09-04 13:54 ` Greg Kroah-Hartman
2024-09-04 14:26 ` Zijun Hu [this message]
2024-09-04 14:44 ` Greg Kroah-Hartman
2024-09-04 15:42 ` Zijun Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b79fb55-26d7-4966-9260-d3cdf3e0e8c8@icloud.com \
--to=zijun_hu@icloud.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®