mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: shijie001@208suo.com
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org
Cc: hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] KVM: x86: Fix errors & warnings in irq_comm.c
Date: Wed, 12 Jul 2023 14:21:54 +0800	[thread overview]
Message-ID: <1b85fe6bf831ffd0b994a9703e8b06f7@208suo.com> (raw)
In-Reply-To: <tencent_63276CF92B7FBBDB6AACD9CB27A3C9B0ED07@qq.com>

The following checkpatch errors & warnings are removed:
WARNING: Missing a blank line after declarations
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
ERROR: Macros with complex values should be enclosed in parentheses

Signed-off-by: Jie Shi <shijie001@208suo.com>
---
  arch/x86/kvm/irq_comm.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/irq_comm.c b/arch/x86/kvm/irq_comm.c
index 16d076a1b91a..38a759606bef 100644
--- a/arch/x86/kvm/irq_comm.c
+++ b/arch/x86/kvm/irq_comm.c
@@ -32,6 +32,7 @@ static int kvm_set_pic_irq(struct 
kvm_kernel_irq_routing_entry *e,
                 bool line_status)
  {
      struct kvm_pic *pic = kvm->arch.vpic;
+
      return kvm_pic_set_irq(pic, e->irqchip.pin, irq_source_id, level);
  }

@@ -40,6 +41,7 @@ static int kvm_set_ioapic_irq(struct 
kvm_kernel_irq_routing_entry *e,
                    bool line_status)
  {
      struct kvm_ioapic *ioapic = kvm->arch.vioapic;
+
      return kvm_ioapic_set_irq(ioapic, e->irqchip.pin, irq_source_id, 
level,
                  line_status);
  }
@@ -253,7 +255,7 @@ void kvm_unregister_irq_mask_notifier(struct kvm 
*kvm, int irq,
      synchronize_srcu(&kvm->irq_srcu);
  }

-void kvm_fire_mask_notifiers(struct kvm *kvm, unsigned irqchip, 
unsigned pin,
+void kvm_fire_mask_notifiers(struct kvm *kvm, unsigned int irqchip, 
unsigned int pin,
                   bool mask)
  {
      struct kvm_irq_mask_notifier *kimn;
@@ -365,7 +367,7 @@ EXPORT_SYMBOL_GPL(kvm_intr_is_single_vcpu);

  #define PIC_ROUTING_ENTRY(irq) \
      { .gsi = irq, .type = KVM_IRQ_ROUTING_IRQCHIP,    \
-      .u.irqchip = { .irqchip = SELECT_PIC(irq), .pin = (irq) % 8 } }
+      .u.irqchip = { .irqchip = SELECT_PIC(irq), .pin = ((irq) % 8) } }
  #define ROUTING_ENTRY2(irq) \
      IOAPIC_ROUTING_ENTRY(irq), PIC_ROUTING_ENTRY(irq)

       reply	other threads:[~2023-07-12  6:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_63276CF92B7FBBDB6AACD9CB27A3C9B0ED07@qq.com>
2023-07-12  6:21 ` shijie001 [this message]
2023-07-18  6:46   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b85fe6bf831ffd0b994a9703e8b06f7@208suo.com \
    --to=shijie001@208suo.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®