From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: shijie001@208suo.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org
Cc: hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Fix errors & warnings in irq_comm.c
Date: Tue, 18 Jul 2023 08:46:41 +0200 [thread overview]
Message-ID: <34c52f9b-df4c-1b02-8419-b9b4fb18dd70@linaro.org> (raw)
In-Reply-To: <1b85fe6bf831ffd0b994a9703e8b06f7@208suo.com>
On 12/7/23 08:21, shijie001@208suo.com wrote:
> ERROR: Macros with complex values should be enclosed in parentheses
>
> Signed-off-by: Jie Shi <shijie001@208suo.com>
> ---
> arch/x86/kvm/irq_comm.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> @@ -365,7 +367,7 @@ EXPORT_SYMBOL_GPL(kvm_intr_is_single_vcpu);
>
> #define PIC_ROUTING_ENTRY(irq) \
> { .gsi = irq, .type = KVM_IRQ_ROUTING_IRQCHIP, \
> - .u.irqchip = { .irqchip = SELECT_PIC(irq), .pin = (irq) % 8 } }
The value is already enclosed in parentheses... False positive?
> + .u.irqchip = { .irqchip = SELECT_PIC(irq), .pin = ((irq) % 8) } }
> #define ROUTING_ENTRY2(irq) \
> IOAPIC_ROUTING_ENTRY(irq), PIC_ROUTING_ENTRY(irq)
prev parent reply other threads:[~2023-07-18 6:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_63276CF92B7FBBDB6AACD9CB27A3C9B0ED07@qq.com>
2023-07-12 6:21 ` shijie001
2023-07-18 6:46 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34c52f9b-df4c-1b02-8419-b9b4fb18dd70@linaro.org \
--to=philmd@linaro.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=shijie001@208suo.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®