Re: [2.6 patch] iwlwifi: move the selects to the tristate drivers

["Tomas Winkler" <tomasw@gmail.com>]

On 4/29/08, John W. Linville <linville@tuxdriver.com> wrote:
> On Mon, Apr 28, 2008 at 11:58:49PM +0300, Adrian Bunk wrote:
>
> > This patch moves the following select's:
> > - RFKILL        : IWLWIFI_RFKILL -> IWLCORE
> > - RFKILL_INPUT  : IWLWIFI_RFKILL -> IWLCORE
> > - MAC80211_LEDS : IWL4965_LEDS   -> IWLCORE
> > - LEDS_CLASS    : IWL4965_LEDS   -> IWLCORE
> > - MAC80211_LEDS : IWL3945_LEDS   -> IWL3945
> > - LEDS_CLASS    : IWL3945_LEDS   -> IWL3945
> >
> > The effects are:
> > - with IWLCORE=m and/or IWL3945=m RFKILL/RFKILL_INPUT/MAC80211_LEDS/LEDS_CLASS
> >   are no longer wrongly forced to y
> > - fixes a build error with IWLCORE=y, IWL4965=m
> >   might be a bug in kconfig causing it, but doing this change that is
> >   anyway the right thing fixes it
> >
> > Reported-by: Carlos R. Mafra <crmafra2@gmail.com>
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> This seems sane to me -- I'm sorry I let so much Kconfig mess slip
> through on this driver in the first place!

I'm sorry too, this is just so no intuitive... I'm really amazed where
it get into yet constrain computation is always complex.  Next time I
put more effort in this.

Tomas

> > ---
> >
> > BTW: There's no correlation between IWL3945_LEDS and IWLWIFI_LEDS.
> >      That seems to be intended?
>
> Yes.  IWLWIFI_LEDS used to be IWL4965_LEDS, and I have the impression
> that eventually it will subsume IWL3945_LEDS as well.
>
True, not yet.



Thanks
Tomas