From: "Carlos R. Mafra" <crmafra2@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: reinette.chatre@intel.com, linville@tuxdriver.com,
torvalds@linux-foundation.org
Subject: [PATCH] iwlwifi: Fix build error in v2.6.25-5561-g064922a
Date: Mon, 28 Apr 2008 02:47:01 -0300 [thread overview]
Message-ID: <20080428054700.GA16177@Pilar.virtua.com.br> (raw)
I've just tried to compile v2.6.25-5561-g064922a and it failed with
these messages:
drivers/built-in.o: In function `iwl_leds_unregister_led':
iwl-led.c:(.text+0x7f14a): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `iwl_leds_register_led':
iwl-led.c:(.text+0x7f220): undefined reference to `led_classdev_register'
make: *** [.tmp_vmlinux1] Error 1
and I checked that it was due to CONFIG_IWL4965_LEDS=y and
CONFIG_LEDS_CLASS=m in my .config.
If I CONFIG_LEDS_CLASS is also =y then it builds fine.
So I tried to cook up a patch to avoid that. It doesn't look
elegant but it avoids this problem for me :-)
--
>From 7116035343f4d031807aa73c92434eab3863de56 Mon Sep 17 00:00:00 2001
From: Carlos R. Mafra <crmafra@ift.unesp.br>
Date: Mon, 28 Apr 2008 02:12:22 -0300
Subject: [PATCH] iwlwifi: Fix build failure due to CONFIG_LEDS_CLASS=m
The compilation of v2.6.25-5561-g064922a fails with
drivers/built-in.o: In function `iwl_leds_unregister_led':
iwl-led.c:(.text+0x7f14a): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `iwl_leds_register_led':
iwl-led.c:(.text+0x7f220): undefined reference to `led_classdev_register'
make: *** [.tmp_vmlinux1] Error 1
and this is the relevant part of .config which caused it
CONFIG_MAC80211_LEDS=y
CONFIG_IWLWIFI_LEDS=y
CONFIG_IWL4965_LEDS=y
CONFIG_LEDS_CLASS=m
The problem was that CONFIG_IWL_4965_LEDS was compiled in and
CONFIG_LEDS_CLASS was modular. To avoid this build failure
make IWL_4965_LEDS depend on LEDS_CLASS=y.
Signed-off-by: Carlos R. Mafra <crmafra@ift.unesp.br>
---
drivers/net/wireless/iwlwifi/Kconfig | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig
index c4e631d..6081f92 100644
--- a/drivers/net/wireless/iwlwifi/Kconfig
+++ b/drivers/net/wireless/iwlwifi/Kconfig
@@ -49,9 +49,8 @@ config IWL4965_HT
config IWL4965_LEDS
bool "Enable LEDS features in iwl4965 driver"
- depends on IWL4965
+ depends on IWL4965 && LEDS_CLASS = y
select MAC80211_LEDS
- select LEDS_CLASS
select IWLWIFI_LEDS
---help---
This option enables LEDS for the iwlwifi drivers
--
1.5.4.3.220.g99d8e
next reply other threads:[~2008-04-28 5:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 5:47 Carlos R. Mafra [this message]
2008-04-28 6:35 ` David Miller
2008-04-28 7:32 ` Carlos R. Mafra
2008-04-28 13:15 ` Adrian Bunk
2008-04-28 14:21 ` Carlos R. Mafra
2008-04-28 20:58 ` [2.6 patch] iwlwifi: move the selects to the tristate drivers Adrian Bunk
2008-04-28 23:45 ` John W. Linville
2008-04-29 1:07 ` Tomas Winkler
2008-04-30 5:30 ` David Miller
2008-04-30 5:30 ` David Miller
2008-04-30 13:31 ` Carlos R. Mafra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428054700.GA16177@Pilar.virtua.com.br \
--to=crmafra2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®