From: "André Draszik" <andre.draszik@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Jon Hunter <jonathanh@nvidia.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>,
Juan Yescas <jyescas@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] regulator: core: remove dead code in regulator_resolve_supply()
Date: Mon, 29 Dec 2025 06:43:51 +0000 [thread overview]
Message-ID: <1baa0a0e89385b7ca8f56f65efd79a42f3eeaa74.camel@linaro.org> (raw)
In-Reply-To: <aVA7FFy-weCynspH@sirena.co.uk>
Hi Mark,
On Sat, 2025-12-27 at 20:01 +0000, Mark Brown wrote:
> On Sat, Dec 27, 2025 at 12:17:49PM +0000, André Draszik wrote:
>
> > No functional change intended.
>
> > Fixes: 98e48cd9283d ("regulator: core: resolve supply for boot-on/always-on regulators")
>
> If this is just a cleanup then clearly it's not fixing a bug. Please
> don't throw Fixes tags on random commits that don't actually fix bugs,
> it just makes noise for people who are looking for actual fixes.
I added it to highlight that the dead code removal should have been
part of that commit, but left out CC:stable for the reason that this
commit is not strictly required. Especially the now incorrect comment
in the code was a bit confusing since that commit, and I wanted to make
it easier for future reader of that code, no matter which kernel version
somebody else might be looking at.
Anyway, will drop in next version.
Cheers,
Andre'
next prev parent reply other threads:[~2025-12-29 6:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-27 12:17 [PATCH 0/8] regulator: core: allow regulator_register() with missing required supply André Draszik
2025-12-27 12:17 ` [PATCH 1/8] regulator: core: update two debug messages André Draszik
2025-12-27 12:17 ` [PATCH 2/8] regulator: core: fix locking in regulator_resolve_supply() error path André Draszik
2025-12-27 12:17 ` [PATCH 3/8] regulator: core: move supply check earlier in set_machine_constraints() André Draszik
2025-12-27 12:17 ` [PATCH 4/8] regulator: core: streamline supply resolution for always-on/boot-on regulators André Draszik
2025-12-27 12:17 ` [PATCH 5/8] regulator: core: remove dead code in regulator_resolve_supply() André Draszik
2025-12-27 20:01 ` Mark Brown
2025-12-29 6:43 ` André Draszik [this message]
2025-12-27 12:17 ` [PATCH 6/8] regulator: core: don't ignore errors from event forwarding setup André Draszik
2025-12-27 12:17 ` [PATCH 7/8] regulator: core: reresolve unresolved supplies when available André Draszik
2025-12-27 12:17 ` [PATCH 8/8] regulator: core: don't fail regulator_register() with missing required supply André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1baa0a0e89385b7ca8f56f65efd79a42f3eeaa74.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=broonie@kernel.org \
--cc=javier@osg.samsung.com \
--cc=jonathanh@nvidia.com \
--cc=jyescas@google.com \
--cc=kernel-team@android.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=peter.griffin@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®