* Re: [PATCH] lightnvm: use kobj_to_dev()
[not found] <20210222060650.45373-1-chaitanya.kulkarni@wdc.com>
@ 2021-02-22 7:35 ` Matias Bjørling
0 siblings, 0 replies; only message in thread
From: Matias Bjørling @ 2021-02-22 7:35 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-nvme, linux-block, linux-kernel
On 22/02/2021 07.06, Chaitanya Kulkarni wrote:
> This fixs coccicheck warning:-
>
> drivers/nvme//host/lightnvm.c:1243:60-61: WARNING opportunity for
> kobj_to_dev()
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> drivers/nvme/host/lightnvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
> index b705988629f2..e3240d189093 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -1240,7 +1240,7 @@ static struct attribute *nvm_dev_attrs[] = {
> static umode_t nvm_dev_attrs_visible(struct kobject *kobj,
> struct attribute *attr, int index)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct gendisk *disk = dev_to_disk(dev);
> struct nvme_ns *ns = disk->private_data;
> struct nvm_dev *ndev = ns->ndev;
Thanks, Chaitanya. I'll pull it in.
^ permalink raw reply [flat|nested] only message in thread