mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Finn Thain <fthain@telegraphics.com.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
	<linuxppc-dev@lists.ozlabs.org>,
	<linux-m68k@lists.linux-m68k.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v4 02/11] macintosh/via-pmu: Add missing mmio accessors
Date: Mon,  2 Jul 2018 04:21:18 -0400 (EDT)	[thread overview]
Message-ID: <1bb42998af67f39088431f00f3f53d739a330dfd.1530519301.git.fthain@telegraphics.com.au> (raw)
In-Reply-To: <cover.1530519301.git.fthain@telegraphics.com.au>

Add missing in_8() accessors to init_pmu() and pmu_sr_intr().

This fixes several sparse warnings:
drivers/macintosh/via-pmu.c:536:29: warning: dereference of noderef expression
drivers/macintosh/via-pmu.c:537:33: warning: dereference of noderef expression
drivers/macintosh/via-pmu.c:1455:17: warning: dereference of noderef expression
drivers/macintosh/via-pmu.c:1456:69: warning: dereference of noderef expression

Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/macintosh/via-pmu.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index f8a2c917201f..ba41220f618e 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -534,8 +534,9 @@ init_pmu(void)
 	int timeout;
 	struct adb_request req;
 
-	out_8(&via[B], via[B] | TREQ);			/* negate TREQ */
-	out_8(&via[DIRB], (via[DIRB] | TREQ) & ~TACK);	/* TACK in, TREQ out */
+	/* Negate TREQ. Set TACK to input and TREQ to output. */
+	out_8(&via[B], in_8(&via[B]) | TREQ);
+	out_8(&via[DIRB], (in_8(&via[DIRB]) | TREQ) & ~TACK);
 
 	pmu_request(&req, NULL, 2, PMU_SET_INTR_MASK, pmu_intr_mask);
 	timeout =  100000;
@@ -1418,8 +1419,8 @@ pmu_sr_intr(void)
 	struct adb_request *req;
 	int bite = 0;
 
-	if (via[B] & TREQ) {
-		printk(KERN_ERR "PMU: spurious SR intr (%x)\n", via[B]);
+	if (in_8(&via[B]) & TREQ) {
+		printk(KERN_ERR "PMU: spurious SR intr (%x)\n", in_8(&via[B]));
 		out_8(&via[IFR], SR_INT);
 		return NULL;
 	}
-- 
2.16.4


  reply	other threads:[~2018-07-02  8:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02  8:21 [PATCH v4 00/11] macintosh: Resolve various PMU driver problems Finn Thain
2018-07-02  8:21 ` Finn Thain [this message]
2018-07-02  8:21 ` [PATCH v4 03/11] macintosh/via-pmu: Don't clear shift register interrupt flag twice Finn Thain
2018-07-02  8:21 ` [PATCH v4 04/11] macintosh/via-pmu: Enhance state machine with new 'uninitialized' state Finn Thain
2018-07-02  8:21 ` [PATCH v4 01/11] macintosh/via-pmu: Fix section mismatch warning Finn Thain
2018-07-02 10:35   ` Mathieu Malaterre
2018-07-02 12:07     ` Finn Thain
2018-08-01  5:23   ` [v4,01/11] " Michael Ellerman
2018-07-02  8:21 ` [PATCH v4 05/11] macintosh/via-pmu: Replace via pointer with via1 and via2 pointers Finn Thain
2018-07-02  8:21 ` [PATCH v4 10/11] macintosh/via-pmu: Clean up interrupt statistics Finn Thain
2018-07-02  8:21 ` [PATCH v4 07/11] macintosh/via-pmu: Explicitly specify CONFIG_PPC_PMAC dependencies Finn Thain
2018-07-02  8:21 ` [PATCH v4 08/11] macintosh/via-pmu68k: Don't load driver on unsupported hardware Finn Thain
2018-07-30  7:23   ` Geert Uytterhoeven
2018-07-02  8:21 ` [PATCH v4 09/11] macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver Finn Thain
2018-07-30  6:47   ` Michael Ellerman
2018-07-30  7:27     ` Geert Uytterhoeven
2018-07-30 13:32       ` Michael Ellerman
2018-07-30  7:26   ` Geert Uytterhoeven
2018-07-30  7:27     ` Geert Uytterhoeven
2018-07-02  8:21 ` [PATCH v4 06/11] macintosh/via-pmu: Add support for m68k PowerBooks Finn Thain
2018-07-02  8:21 ` [PATCH v4 11/11] macintosh/via-pmu: Disambiguate interrupt statistics Finn Thain
2018-07-28  7:08 ` [PATCH v4 00/11] macintosh: Resolve various PMU driver problems Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bb42998af67f39088431f00f3f53d739a330dfd.1530519301.git.fthain@telegraphics.com.au \
    --to=fthain@telegraphics.com.au \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=schmitzmic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®