[PATCH -next] x86/platform/uv: Mark some symbols with static keyword

[PATCH -next] x86/platform/uv: Mark some symbols with static keyword

[Zou Wei]

Fix the following sparse warnings:

drivers/platform/x86/uv_sysfs.c:22:13: warning: symbol 'uv_pcibus_kset' was not declared. Should it be static?
drivers/platform/x86/uv_sysfs.c:23:13: warning: symbol 'uv_hubs_kset' was not declared. Should it be static?

Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/platform/x86/uv_sysfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c
index 54c3425..c780a4b 100644
--- a/drivers/platform/x86/uv_sysfs.c
+++ b/drivers/platform/x86/uv_sysfs.c
@@ -19,8 +19,8 @@
 #define INVALID_CNODE -1
 
 struct kobject *sgi_uv_kobj;
-struct kset *uv_pcibus_kset;
-struct kset *uv_hubs_kset;
+static struct kset *uv_pcibus_kset;
+static struct kset *uv_hubs_kset;
 static struct uv_bios_hub_info *hub_buf;
 static struct uv_bios_port_info **port_buf;
 static struct uv_hub **uv_hubs;
-- 
2.6.2

Re: [PATCH -next] x86/platform/uv: Mark some symbols with static keyword

[Hans de Goede]

Hi,

+Cc x86 folks

On 11/30/20 12:11 PM, Zou Wei wrote:
> Fix the following sparse warnings:
> 
> drivers/platform/x86/uv_sysfs.c:22:13: warning: symbol 'uv_pcibus_kset' was not declared. Should it be static?
> drivers/platform/x86/uv_sysfs.c:23:13: warning: symbol 'uv_hubs_kset' was not declared. Should it be static?
> 
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Since this is a fix to a series merged through the x86/tip tree, this should be merged
to the x86/tip tree too (or I can pick it up after 5.11-rc1).

Here is my ack for merging this through the x86/tip tree:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>  drivers/platform/x86/uv_sysfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c
> index 54c3425..c780a4b 100644
> --- a/drivers/platform/x86/uv_sysfs.c
> +++ b/drivers/platform/x86/uv_sysfs.c
> @@ -19,8 +19,8 @@
>  #define INVALID_CNODE -1
>  
>  struct kobject *sgi_uv_kobj;
> -struct kset *uv_pcibus_kset;
> -struct kset *uv_hubs_kset;
> +static struct kset *uv_pcibus_kset;
> +static struct kset *uv_hubs_kset;
>  static struct uv_bios_hub_info *hub_buf;
>  static struct uv_bios_port_info **port_buf;
>  static struct uv_hub **uv_hubs;
> 

答复: [PATCH -next] x86/platform/uv: Mark some symbols with static keyword

[Zouwei (Samuel)]

Hi,

Please help to pick it up after 5.11-rc1, thanks a lot.

-----邮件原件-----
发件人: Hans de Goede [mailto:hdegoede@redhat.com] 
发送时间: 2020年11月30日 21:31
收件人: Zouwei (Samuel) <zou_wei@huawei.com>; justin.ernst@hpe.com; mgross@linux.intel.com
抄送: platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org; x86@kernel.org
主题: Re: [PATCH -next] x86/platform/uv: Mark some symbols with static keyword

Hi,

+Cc x86 folks

On 11/30/20 12:11 PM, Zou Wei wrote:
> Fix the following sparse warnings:
> 
> drivers/platform/x86/uv_sysfs.c:22:13: warning: symbol 'uv_pcibus_kset' was not declared. Should it be static?
> drivers/platform/x86/uv_sysfs.c:23:13: warning: symbol 'uv_hubs_kset' was not declared. Should it be static?
> 
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Since this is a fix to a series merged through the x86/tip tree, this should be merged to the x86/tip tree too (or I can pick it up after 5.11-rc1).

Here is my ack for merging this through the x86/tip tree:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>  drivers/platform/x86/uv_sysfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/uv_sysfs.c 
> b/drivers/platform/x86/uv_sysfs.c index 54c3425..c780a4b 100644
> --- a/drivers/platform/x86/uv_sysfs.c
> +++ b/drivers/platform/x86/uv_sysfs.c
> @@ -19,8 +19,8 @@
>  #define INVALID_CNODE -1
>  
>  struct kobject *sgi_uv_kobj;
> -struct kset *uv_pcibus_kset;
> -struct kset *uv_hubs_kset;
> +static struct kset *uv_pcibus_kset;
> +static struct kset *uv_hubs_kset;
>  static struct uv_bios_hub_info *hub_buf;  static struct 
> uv_bios_port_info **port_buf;  static struct uv_hub **uv_hubs;
> 

[tip: x86/platform] x86/platform/uv: Make uv_pcibus_kset and uv_hubs_kset static

[tip-bot2 for Zou Wei]

The following commit has been merged into the x86/platform branch of tip:

Commit-ID:     0c683e9de0c78ee53e220eac9ee3604ca662737a
Gitweb:        https://git.kernel.org/tip/0c683e9de0c78ee53e220eac9ee3604ca662737a
Author:        Zou Wei <zou_wei@huawei.com>
AuthorDate:    Mon, 30 Nov 2020 19:11:53 +08:00
Committer:     Borislav Petkov <bp@suse.de>
CommitterDate: Thu, 03 Dec 2020 08:53:47 +01:00

x86/platform/uv: Make uv_pcibus_kset and uv_hubs_kset static

Fix the following sparse warnings:

  drivers/platform/x86/uv_sysfs.c:22:13: warning: symbol \
	  'uv_pcibus_kset' was not declared. Should it be static?
  drivers/platform/x86/uv_sysfs.c:23:13: warning: symbol \
	  'uv_hubs_kset' was not declared. Should it be static?

Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lkml.kernel.org/r/1606734713-43919-1-git-send-email-zou_wei@huawei.com
---
 drivers/platform/x86/uv_sysfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c
index e17ce8c..c27f5ff 100644
--- a/drivers/platform/x86/uv_sysfs.c
+++ b/drivers/platform/x86/uv_sysfs.c
@@ -19,8 +19,8 @@
 #define INVALID_CNODE -1
 
 struct kobject *sgi_uv_kobj;
-struct kset *uv_pcibus_kset;
-struct kset *uv_hubs_kset;
+static struct kset *uv_pcibus_kset;
+static struct kset *uv_hubs_kset;
 static struct uv_bios_hub_info *hub_buf;
 static struct uv_bios_port_info **port_buf;
 static struct uv_hub **uv_hubs;