From: linmiaohe <linmiaohe@huawei.com>
To: "mingo@redhat.com" <mingo@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"bsegall@google.com" <bsegall@google.com>,
"mgorman@suse.de" <mgorman@suse.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: Fix some comments
Date: Thu, 24 Sep 2020 13:04:52 +0000 [thread overview]
Message-ID: <1c13c996946449f58d607e7a94c54a93@huawei.com> (raw)
Friendly ping. :)
> Since commit dfa50b605c2a ("sched: Make finish_task_switch() return 'struct rq *'"), prev == current is incorrect in finish_task_switch(). Also fix a typo in the comment of struct dl_bandwidth.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> kernel/sched/core.c | 4 ++--
> kernel/sched/sched.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 8471a0f7eb32..725ccab230da 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -3571,8 +3571,8 @@ prepare_task_switch(struct rq *rq, struct task_struct *prev,
> *
> * The context switch have flipped the stack from under us and restored the
> * local variables which were saved when this task called schedule() in the
> - * past. prev == current is still correct but we need to recalculate this_rq
> - * because prev may have moved to another CPU.
> + * past. We need to recalculate this_rq because prev may have moved to
> + * another CPU.
> */
> static struct rq *finish_task_switch(struct task_struct *prev)
> __releases(rq->lock)
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 28709f6b0975..1d7e45f7fbb9 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -278,7 +278,7 @@ void __dl_clear_params(struct task_struct *p);
> * consume bandwidth on the CPU they're running on.
> * Finally, dl_total_bw_cpu is used to cache the index of dl_total_bw
> * that will be shown the next time the proc or cgroup controls will
> - * be red. It on its turn can be changed by writing on its own
> + * be read. It on its turn can be changed by writing on its own
> * control.
> */
> struct dl_bandwidth {
> --
> 2.19.1
>
next reply other threads:[~2020-09-24 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 13:04 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-05 9:27 Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c13c996946449f58d607e7a94c54a93@huawei.com \
--to=linmiaohe@huawei.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®