Re: [PATCH v5 0/7] eCryptfs: added support for the encrypted key type

Re: [PATCH v5 0/7] eCryptfs: added support for the encrypted key type

[lkml]

Hi there, 


Either this is completely braindead, or I'm missing something very obvious. 
Why mess up encrypted keys with various "format" fixes. 
I hope this doesn't start a trend. 

The right (and disturbingly simpler) approach to fixing the auth_token vs. 
raw key material issue would be to put the fix in eCryptfs. 

In fact, all the relevant bits for filling the token from the key_desc/sig should be moved 
from security/keys/encrypted/ecryptfs_format.c to fs/ecryptfs/ecryptfs_kernel.h, 
and all the format cruft in encrypted-keys reverted. 
Then pretty much any "default" encrypted key could be used for ecryptfs… 

What am I missing? 


--@;

---
posted at http://www.serverphorums.com
http://www.serverphorums.com/read.php?12,341340,618745#msg-618745

[PATCH v5 0/7] eCryptfs: added support for the encrypted key type

[Roberto Sassu]

[-- Attachment #1: Type: text/plain, Size: 1670 bytes --]

This patch set adds support for the 'encrypted' key type in the eCryptfs
filesystem.

Changelog from version v4:
 - rebased on the kernel version 3.0-rc4;
 - fixed master key dumping in request_master_key() when debug is enabled;
 - made more understandable the debug messages added in the patch 3/7.

Roberto Sassu


Roberto Sassu (7):
  encrypted_keys: avoid dumping the master key if the request fails
  encrypted-keys: fixed valid_master_desc() function description
  encrypted-keys: added additional debug messages
  encrypted-keys: add key format support
  eCryptfs: export global eCryptfs definitions to
    include/linux/ecryptfs.h
  encrypted-keys: add ecryptfs format support
  eCryptfs: added support for the encrypted key type

 Documentation/keys-ecryptfs.txt                   |   68 ++++++
 Documentation/security/keys-trusted-encrypted.txt |   52 +++--
 fs/ecryptfs/ecryptfs_kernel.h                     |  150 ++++---------
 fs/ecryptfs/keystore.c                            |   13 +-
 include/keys/encrypted-type.h                     |   13 +-
 include/linux/ecryptfs.h                          |  113 +++++++++
 security/keys/Makefile                            |    2 +-
 security/keys/ecryptfs_format.c                   |   81 +++++++
 security/keys/ecryptfs_format.h                   |   30 +++
 security/keys/encrypted.c                         |  251 ++++++++++++++++-----
 10 files changed, 584 insertions(+), 189 deletions(-)
 create mode 100644 Documentation/keys-ecryptfs.txt
 create mode 100644 include/linux/ecryptfs.h
 create mode 100644 security/keys/ecryptfs_format.c
 create mode 100644 security/keys/ecryptfs_format.h

-- 
1.7.4.4


[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 2061 bytes --]