From: "Yu Kuai" <yukuai@fnnas.com>
To: "Hannes Reinecke" <hare@suse.de>, <axboe@kernel.dk>,
<nilay@linux.ibm.com>, <bvanassche@acm.org>,
<linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Yu Kuai" <yukuai@fnnas.com>
Subject: Re: [PATCH v6 6/8] mq-deadline: covert to use request_queue->async_depth
Date: Fri, 21 Nov 2025 20:28:36 +0800 [thread overview]
Message-ID: <1c2e8761-5344-4300-a2bf-9e80b3983968@fnnas.com> (raw)
In-Reply-To: <c93e88cd-ade4-4264-8d80-a6669e361c32@suse.de>
Hi,
在 2025/11/21 15:18, Hannes Reinecke 写道:
> ... and this is now the opposite. We are removing an existing attribute
> (raising questions about userland ABI stability).
> Wouldn't it be better to use the generic infrastructure (ie having a
> per-request queue async_depth variable), but keep the per-elevator
> sysfs attributes (which then just would display the per-queue variable).
>
The problem is we can't make this api inside elevator writable as it
used to be, and if user do use this, they will probably write it to
limit async requests.
And I feel it will be acceptable for this kind of user api compatibility,
replace it elsewhere with the same functionality when kernel version is
updated.
> That way we won't break userland and get around the awkward issue
> of presenting a dummy attribute when no elevator is loaded.
--
Thanks,
Kuai
next prev parent reply other threads:[~2025-11-21 12:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 5:28 [PATCH v6 0/8] blk-mq: introduce new queue attribute async_depth Yu Kuai
2025-11-21 5:28 ` [PATCH v6 1/8] block: convert nr_requests to unsigned int Yu Kuai
2025-11-21 7:09 ` Hannes Reinecke
2025-11-21 5:28 ` [PATCH v6 2/8] blk-mq-sched: unify elevators checking for async requests Yu Kuai
2025-11-21 7:09 ` Hannes Reinecke
2025-11-21 5:28 ` [PATCH v6 3/8] blk-mq: factor out a helper blk_mq_limit_depth() Yu Kuai
2025-11-21 7:10 ` Hannes Reinecke
2025-11-21 5:28 ` [PATCH v6 4/8] blk-mq: add a new queue sysfs attribute async_depth Yu Kuai
2025-11-21 7:14 ` Hannes Reinecke
2025-11-21 12:17 ` Yu Kuai
2025-11-21 5:28 ` [PATCH v6 5/8] kyber: covert to use request_queue->async_depth Yu Kuai
2025-11-21 5:28 ` [PATCH v6 6/8] mq-deadline: " Yu Kuai
2025-11-21 7:18 ` Hannes Reinecke
2025-11-21 12:28 ` Yu Kuai [this message]
2025-11-21 5:28 ` [PATCH v6 7/8] block, bfq: convert " Yu Kuai
2025-11-21 5:28 ` [PATCH v6 8/8] blk-mq: add documentation for new queue attribute async_dpeth Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c2e8761-5344-4300-a2bf-9e80b3983968@fnnas.com \
--to=yukuai@fnnas.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®