mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Yu Kuai <yukuai@fnnas.com>,
	axboe@kernel.dk, nilay@linux.ibm.com, bvanassche@acm.org,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/8] blk-mq-sched: unify elevators checking for async requests
Date: Fri, 21 Nov 2025 08:09:37 +0100	[thread overview]
Message-ID: <4171e102-855b-43a2-bef0-dc0b42868827@suse.de> (raw)
In-Reply-To: <20251121052901.1341976-3-yukuai@fnnas.com>

On 11/21/25 06:28, Yu Kuai wrote:
> bfq and mq-deadline consider sync writes as async requests and only
> reserve tags for sync reads by async_depth, however, kyber doesn't
> consider sync writes as async requests for now.
> 
> Consider the case there are lots of dirty pages, and user use fsync to
> flush dirty pages. In this case sched_tags can be exhausted by sync writes
> and sync reads can stuck waiting for tag. Hence let kyber follow what
> mq-deadline and bfq did, and unify async requests checking for all
> elevators.
> 
> Signed-off-by: Yu Kuai <yukuai@fnnas.com>
> Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
> ---
>   block/bfq-iosched.c   | 2 +-
>   block/blk-mq-sched.h  | 5 +++++
>   block/kyber-iosched.c | 2 +-
>   block/mq-deadline.c   | 2 +-
>   4 files changed, 8 insertions(+), 3 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich

  reply	other threads:[~2025-11-21  7:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21  5:28 [PATCH v6 0/8] blk-mq: introduce new queue attribute async_depth Yu Kuai
2025-11-21  5:28 ` [PATCH v6 1/8] block: convert nr_requests to unsigned int Yu Kuai
2025-11-21  7:09   ` Hannes Reinecke
2025-11-21  5:28 ` [PATCH v6 2/8] blk-mq-sched: unify elevators checking for async requests Yu Kuai
2025-11-21  7:09   ` Hannes Reinecke [this message]
2025-11-21  5:28 ` [PATCH v6 3/8] blk-mq: factor out a helper blk_mq_limit_depth() Yu Kuai
2025-11-21  7:10   ` Hannes Reinecke
2025-11-21  5:28 ` [PATCH v6 4/8] blk-mq: add a new queue sysfs attribute async_depth Yu Kuai
2025-11-21  7:14   ` Hannes Reinecke
2025-11-21 12:17     ` Yu Kuai
2025-11-21  5:28 ` [PATCH v6 5/8] kyber: covert to use request_queue->async_depth Yu Kuai
2025-11-21  5:28 ` [PATCH v6 6/8] mq-deadline: " Yu Kuai
2025-11-21  7:18   ` Hannes Reinecke
2025-11-21 12:28     ` Yu Kuai
2025-11-21  5:28 ` [PATCH v6 7/8] block, bfq: convert " Yu Kuai
2025-11-21  5:28 ` [PATCH v6 8/8] blk-mq: add documentation for new queue attribute async_dpeth Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4171e102-855b-43a2-bef0-dc0b42868827@suse.de \
    --to=hare@suse.de \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nilay@linux.ibm.com \
    --cc=yukuai@fnnas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®