Re: [PATCH v8 0/2] Change mmsys compatible for mt8195 mediatek-drm

Re: [PATCH v8 0/2] Change mmsys compatible for mt8195 mediatek-drm

[AngeloGioacchino Del Regno]

Il 06/03/23 09:06, Jason-JH.Lin ha scritto:
> For previous MediaTek SoCs, such as MT8173, there are 2 display HW
> pipelines binding to 1 mmsys with the same power domain, the same
> clock driver and the same mediatek-drm driver.
> 
> For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding to
> 2 different power domains, different clock drivers and different
> mediatek-drm drivers.
> 
> Moreover, Hardware pipeline of VDOSYS0 has these components: COLOR,
> CCORR, AAL, GAMMA, DITHER. They are related to the PQ (Picture Quality)
> and they makes VDOSYS0 supports PQ function while they are not
> including in VDOSYS1.
> 
> Hardware pipeline of VDOSYS1 has the component ETHDR (HDR related
> component). It makes VDOSYS1 supports the HDR function while it's not
> including in VDOSYS0.
> 
> To summarize0:
> Only VDOSYS0 can support PQ adjustment.
> Only VDOSYS1 can support HDR adjustment.
> 
> Therefore, we need to separate these two different mmsys hardwares to
> 2 different compatibles for MT8195.


Hello Chun-Kuang, Matthias,

Since this series is ready, can you please pick it?

I would imagine that commit [1/2] would go through CK and commit [2/2] goes
through Matthias.

Thanks,
Angelo

Re: [PATCH v8 0/2] Change mmsys compatible for mt8195 mediatek-drm

[Chun-Kuang Hu]

Hi, Angelo:

AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> 於
2023年3月16日 週四 下午5:03寫道：
>
> Il 06/03/23 09:06, Jason-JH.Lin ha scritto:
> > For previous MediaTek SoCs, such as MT8173, there are 2 display HW
> > pipelines binding to 1 mmsys with the same power domain, the same
> > clock driver and the same mediatek-drm driver.
> >
> > For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding to
> > 2 different power domains, different clock drivers and different
> > mediatek-drm drivers.
> >
> > Moreover, Hardware pipeline of VDOSYS0 has these components: COLOR,
> > CCORR, AAL, GAMMA, DITHER. They are related to the PQ (Picture Quality)
> > and they makes VDOSYS0 supports PQ function while they are not
> > including in VDOSYS1.
> >
> > Hardware pipeline of VDOSYS1 has the component ETHDR (HDR related
> > component). It makes VDOSYS1 supports the HDR function while it's not
> > including in VDOSYS0.
> >
> > To summarize0:
> > Only VDOSYS0 can support PQ adjustment.
> > Only VDOSYS1 can support HDR adjustment.
> >
> > Therefore, we need to separate these two different mmsys hardwares to
> > 2 different compatibles for MT8195.
>
>
> Hello Chun-Kuang, Matthias,
>
> Since this series is ready, can you please pick it?
>
> I would imagine that commit [1/2] would go through CK and commit [2/2] goes
> through Matthias.

[1/2] has been applied to mediatek-drm-next [1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

>
> Thanks,
> Angelo
>

Re: [PATCH v8 2/2] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum

[Chen-Yu Tsai]

Hi Matthias,

On Mon, Mar 6, 2023 at 4:07 PM Jason-JH.Lin <jason-jh.lin@mediatek.com> wrote:
>
> After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0,
> mmsys header can remove the useless DDP_COMPONENT_DITHER enum.
>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> Acked-by: Matthias Brugger <matthias.bgg@gmail.com>

CK didn't pick up this patch. Since the other patch already got picked up
in v6.4-rc1, could you merge this for v6.5?


Thanks
ChenYu


> ---
>  include/linux/soc/mediatek/mtk-mmsys.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h
> index dc2963a0a0f7..8eb5846985b4 100644
> --- a/include/linux/soc/mediatek/mtk-mmsys.h
> +++ b/include/linux/soc/mediatek/mtk-mmsys.h
> @@ -27,8 +27,7 @@ enum mtk_ddp_comp_id {
>         DDP_COMPONENT_CCORR,
>         DDP_COMPONENT_COLOR0,
>         DDP_COMPONENT_COLOR1,
> -       DDP_COMPONENT_DITHER,
> -       DDP_COMPONENT_DITHER0 = DDP_COMPONENT_DITHER,
> +       DDP_COMPONENT_DITHER0,
>         DDP_COMPONENT_DITHER1,
>         DDP_COMPONENT_DP_INTF0,
>         DDP_COMPONENT_DP_INTF1,
> --
> 2.18.0
>

Re: [PATCH v8 2/2] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum

[Matthias Brugger]

On 31/05/2023 09:43, Chen-Yu Tsai wrote:
> Hi Matthias,
> 
> On Mon, Mar 6, 2023 at 4:07 PM Jason-JH.Lin <jason-jh.lin@mediatek.com> wrote:
>>
>> After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0,
>> mmsys header can remove the useless DDP_COMPONENT_DITHER enum.
>>
>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
>> Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
> 
> CK didn't pick up this patch. Since the other patch already got picked up
> in v6.4-rc1, could you merge this for v6.5?
> 

Yes, I gave an acked-by as I thought that CK will take both of them. Anyway 
applied now.

Matthias

> 
> Thanks
> ChenYu
> 
> 
>> ---
>>   include/linux/soc/mediatek/mtk-mmsys.h | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h
>> index dc2963a0a0f7..8eb5846985b4 100644
>> --- a/include/linux/soc/mediatek/mtk-mmsys.h
>> +++ b/include/linux/soc/mediatek/mtk-mmsys.h
>> @@ -27,8 +27,7 @@ enum mtk_ddp_comp_id {
>>          DDP_COMPONENT_CCORR,
>>          DDP_COMPONENT_COLOR0,
>>          DDP_COMPONENT_COLOR1,
>> -       DDP_COMPONENT_DITHER,
>> -       DDP_COMPONENT_DITHER0 = DDP_COMPONENT_DITHER,
>> +       DDP_COMPONENT_DITHER0,
>>          DDP_COMPONENT_DITHER1,
>>          DDP_COMPONENT_DP_INTF0,
>>          DDP_COMPONENT_DP_INTF1,
>> --
>> 2.18.0
>>