From: Hannes Reinecke <hare@suse.de>
To: Qiliang Yuan <odys.yuan@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, Ming Lei <tom.leiming@gmail.com>,
Nilay Shroff <nilay@linux.ibm.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Stuart Hayes <stuart.w.hayes@gmail.com>
Subject: Re: [PATCH 1/2] nvme: remove namespaces in parallel
Date: Mon, 2 Nov 2026 10:27:56 +0100 [thread overview]
Message-ID: <1c55b616-d1c5-4929-a4ac-43695ca4f87b@suse.de> (raw)
In-Reply-To: <20261102080041.1269654-1-odys.yuan@gmail.com>
On 11/2/26 9:00 AM, Qiliang Yuan wrote:
> On Mon, 2 Nov 2026 08:26:57 +0100, Hannes Reinecke wrote:
>> On 11/2/26 7:14 AM, Qiliang Yuan wrote:
>>> nvme_remove_namespaces() removes the namespaces of a controller one
>>> after another. Each removal waits for RCU grace periods in
>>> del_gendisk() for the namespace and for its multipath head, about
>>> 20 ms in all.
>>>
>> But that isn't changed by calling async_schedule_domain, isn't it?
>
> Right, each removal still waits about 20 ms. What changes is that the
> waits overlap. A grace period is system-wide, so removals that wait at
> the same time are released by the same grace periods instead of each
> needing its own. Disconnect time over tcp, from the table in the
> patch:
>
So state that in the patch description.
That'll make it easier for people to understand.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2026-11-02 9:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 6:14 [PATCH 0/2] nvme: delete controllers with many namespaces faster Qiliang Yuan
2026-11-02 6:14 ` [PATCH 1/2] nvme: remove namespaces in parallel Qiliang Yuan
2026-11-02 7:26 ` Hannes Reinecke
2026-11-02 8:00 ` Qiliang Yuan
2026-11-02 9:27 ` Hannes Reinecke [this message]
2026-11-02 6:14 ` [PATCH 2/2] block: set QUEUE_FLAG_NO_ELV_SWITCH under the read lock in del_gendisk() Qiliang Yuan
2026-11-02 7:22 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c55b616-d1c5-4929-a4ac-43695ca4f87b@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=odys.yuan@gmail.com \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
--cc=stuart.w.hayes@gmail.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®