[PATCH v2 0/4] Add minimal Samsung Galaxy S20 Series board, SM-G981B and SM-G980F support

[PATCH v2 0/4] Add minimal Samsung Galaxy S20 Series board, SM-G981B and SM-G980F support

[Umer Uddin]

Hi folks,

This series adds initial support for the Samsung Galaxy S20 Series, also
initial board support for the Samsung Galaxy S20 5G (SM-G981B)
codenamed x1s and the Samsung Galaxy S20 (SM-G980F) codenamed
x1slte.

The S20 Series feature a lot of similarities in their configuration
and internally Samsung named the common devicetrees in their
downstream kernel 'hubble', please note hubble excludes the
S20 FE series and Note20 series.
The device trees have been tested with dtbs_check W=1
and results in no warnings.

This initial bringup consists of:
 * pinctrl
 * gpio-keys
 * simple-framebuffer

This is enough to reach a shell in an initramfs. More platform support
will be added in the future.

Just like SM-N981B, the preferred way to boot the upstream kernel is
by using a shim bootloader, called uniLoader [1], which works around
some issues with the stock, non-replacable Samsung S-LK bootloader.
For example, the stock bootloader leaves the decon trigger control
unset, which causes the framebuffer not to refresh.

Device functionality depends on the patch series from Igor Belwon:
"Add minimal Exynos990 SoC and SM-N981B support"

[1] https://github.com/ivoszbg/uniLoader

Changes in v2:
 - Add Samsung Galaxy S20 into device tree bindings
 - Add support for Samsung Galaxy S20 as well as the 5G variant now
 - Fix typo in Samsung Galaxy S20 5G commit message

Kind regards,
Umer

Umer Uddin (4):
  dt-bindings: arm: samsung: samsung-boards: Add bindings for SM-G981B
    and SM-G980F board
  arm64: dts: exynos: Add initial support for Samsung Galaxy S20 Series
    boards (hubble)
  arm64: dts: exynos: Add initial support for Samsung Galaxy S20 5G
    (x1s)
  arm64: dts: exynos: Add initial support for Samsung Galaxy S20
    (x1slte)

 .../bindings/arm/samsung/samsung-boards.yaml  |   2 +
 arch/arm64/boot/dts/exynos/Makefile           |   2 +
 .../dts/exynos/exynos990-hubble-common.dtsi   | 109 ++++++++++++++++++
 arch/arm64/boot/dts/exynos/exynos990-x1s.dts  |  23 ++++
 .../boot/dts/exynos/exynos990-x1slte.dts      |  17 +++
 5 files changed, 153 insertions(+)
 create mode 100644 arch/arm64/boot/dts/exynos/exynos990-hubble-common.dtsi
 create mode 100644 arch/arm64/boot/dts/exynos/exynos990-x1s.dts
 create mode 100644 arch/arm64/boot/dts/exynos/exynos990-x1slte.dts

-- 
2.47.0

[PATCH v2 1/4] dt-bindings: arm: samsung: samsung-boards: Add bindings for SM-G981B and SM-G980F board

[Umer Uddin]

Add devicetree bindings for Samsung Galaxy S20 5G
and Samsung Galaxy S20 board.

Signed-off-by: Umer Uddin <umer.uddin@mentallysanemainliners.org>
---
 .../devicetree/bindings/arm/samsung/samsung-boards.yaml         | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
index d25a17e69..70a915240 100644
--- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
+++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
@@ -234,6 +234,8 @@ properties:
         items:
           - enum:
               - samsung,c1s                     # Samsung Galaxy Note20 5G (SM-N981B)
+              - samsung,x1s                     # Samsung Galaxy S20 5G (SM-G981B)
+	      - samsung,x1slte			# Samsung Galaxy S20 (SM-G980F)
           - const: samsung,exynos990
 
       - description: Exynos Auto v9 based boards
-- 
2.47.0

[PATCH v2 2/4] arm64: dts: exynos: Add initial support for Samsung Galaxy S20 Series boards (hubble)

[Umer Uddin]

Add initial support for the Samsung Galaxy S20 Series (hubble) phones.
They were launched in 2020, and are based on the Exynos 990 SoC.
The devices have multiple RAM configurations,
starting from 8GB going all the way up to 16GB for the S20 Ultra devices.

This device tree adds support for the following:

- SimpleFB
- 8GB RAM (Any more will be mapped in device trees)
- Buttons

Signed-off-by: Umer Uddin <umer.uddin@mentallysanemainliners.org>
---
 .../dts/exynos/exynos990-hubble-common.dtsi   | 109 ++++++++++++++++++
 1 file changed, 109 insertions(+)
 create mode 100644 arch/arm64/boot/dts/exynos/exynos990-hubble-common.dtsi

diff --git a/arch/arm64/boot/dts/exynos/exynos990-hubble-common.dtsi b/arch/arm64/boot/dts/exynos/exynos990-hubble-common.dtsi
new file mode 100644
index 000000000..2c634e4bb
--- /dev/null
+++ b/arch/arm64/boot/dts/exynos/exynos990-hubble-common.dtsi
@@ -0,0 +1,109 @@
+// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
+/*
+ * Samsung Galaxy S20 Series device tree source
+ *
+ * Copyright (c) 2024, Umer Uddin <umer.uddin@mentallysanemainliners.org>
+ */
+
+/dts-v1/;
+#include "exynos990.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+
+/ {
+	chosen {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		framebuffer0: framebuffer@f1000000 {
+			compatible = "simple-framebuffer";
+			reg = <0 0xf1000000 0 (1440 * 3200 * 4)>;
+			width = <1440>;
+			height = <3200>;
+			stride = <(1440 * 4)>;
+			format = "a8r8g8b8";
+		};
+	};
+
+	memory@80000000 {
+		device_type = "memory";
+		reg = <0x0 0x80000000 0x0 0x3ab00000>,
+		      /* Memory hole */
+		      <0x0 0xc1200000 0x0 0x1ee00000>,
+		      /* Memory hole */
+		      <0x0 0xe1900000 0x0 0x1e700000>,
+		      /* Memory hole */
+		      <0x8 0x80000000 0x1 0x7ec00000>;
+	};
+
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		cont_splash_mem: framebuffer@f1000000 {
+			reg = <0 0xf1000000 0 0x1194000>;
+			no-map;
+		};
+
+		abox_reserved: audio@f7fb0000 {
+			reg = <0 0xf7fb0000 0 0x2a50000>;
+			no-map;
+		};
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+
+		pinctrl-0 = <&key_power &key_voldown &key_volup>;
+		pinctrl-names = "default";
+
+		power-key {
+			label = "Power";
+			linux,code = <KEY_POWER>;
+			gpios = <&gpa2 4 GPIO_ACTIVE_LOW>;
+			wakeup-source;
+		};
+
+		voldown-key {
+			label = "Volume Down";
+			linux,code = <KEY_VOLUMEDOWN>;
+			gpios = <&gpa0 4 GPIO_ACTIVE_LOW>;
+		};
+
+		volup-key {
+			label = "Volume Up";
+			linux,code = <KEY_VOLUMEUP>;
+			gpios = <&gpa0 3 GPIO_ACTIVE_LOW>;
+		};
+	};
+};
+
+&oscclk {
+	clock-frequency = <26000000>;
+};
+
+&pinctrl_alive {
+	key_power: key-power-pins {
+		samsung,pins = "gpa2-4";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_EINT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>;
+	};
+
+	key_voldown: key-voldown-pins {
+		samsung,pins = "gpa0-4";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_EINT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>;
+	};
+
+	key_volup: key-volup-pins {
+		samsung,pins = "gpa0-3";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_EINT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>;
+	};
+};
-- 
2.47.0

[PATCH v2 3/4] arm64: dts: exynos: Add initial support for Samsung Galaxy S20 5G (x1s)

[Umer Uddin]

Add initial support for the Samsung Galaxy S20 5G (x1s/SM-G981B)
phone. It was launched in 2020, and it's based on the Exynos 990 SoC. It
has only one configuration with 12GB of RAM and 128GB of UFS 3.0 storage.

This device tree adds support for the following:

- SimpleFB
- 12GB RAM
- Buttons

Signed-off-by: Umer Uddin <umer.uddin@mentallysanemainliners.org>
---
 arch/arm64/boot/dts/exynos/Makefile          |  1 +
 arch/arm64/boot/dts/exynos/exynos990-x1s.dts | 23 ++++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 arch/arm64/boot/dts/exynos/exynos990-x1s.dts

diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile
index 7a934499b..deb8dc509 100644
--- a/arch/arm64/boot/dts/exynos/Makefile
+++ b/arch/arm64/boot/dts/exynos/Makefile
@@ -9,5 +9,6 @@ dtb-$(CONFIG_ARCH_EXYNOS) += \
 	exynos850-e850-96.dtb		\
 	exynos8895-dreamlte.dtb		\
 	exynos990-c1s.dtb		\
+	exynos990-x1s.dtb		\
 	exynosautov9-sadk.dtb		\
 	exynosautov920-sadk.dtb
diff --git a/arch/arm64/boot/dts/exynos/exynos990-x1s.dts b/arch/arm64/boot/dts/exynos/exynos990-x1s.dts
new file mode 100644
index 000000000..f7b1afd0e
--- /dev/null
+++ b/arch/arm64/boot/dts/exynos/exynos990-x1s.dts
@@ -0,0 +1,23 @@
+// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
+/*
+ * Samsung Galaxy S20 5G (x1s/SM-G981B) device tree source
+ *
+ * Copyright (c) 2024, Umer Uddin <umer.uddin@mentallysanemainliners.org>
+ */
+
+/dts-v1/;
+#include "exynos990-hubble-common.dtsi"
+
+/ {
+	#address-cells = <2>;
+	#size-cells = <2>;
+
+	model = "Samsung Galaxy S20 5G";
+	compatible = "samsung,x1s", "samsung,exynos990";
+
+	memory@9fec00000 {
+		device_type = "memory";
+		reg = <0x9 0xfec00000 0x0 0x01400000>,
+		      <0xa 0x0 0x0 0xfe800000>;
+	};
+};
-- 
2.47.0

[PATCH v2 4/4] arm64: dts: exynos: Add initial support for Samsung Galaxy S20 (x1slte)

[Umer Uddin]

Add initial support for the Samsung Galaxy S20 (x1slte/SM-G980F)
phone. It was launched in 2020, and it's based on the Exynos 990 SoC. It
has only one configuration with 8GB of RAM and 128GB of UFS 3.0 storage.

This device tree adds support for the following:

- SimpleFB
- 8GB RAM
- Buttons

Signed-off-by: Umer Uddin <umer.uddin@mentallysanemainliners.org>
---
 arch/arm64/boot/dts/exynos/Makefile             |  1 +
 arch/arm64/boot/dts/exynos/exynos990-x1slte.dts | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 arch/arm64/boot/dts/exynos/exynos990-x1slte.dts

diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile
index deb8dc509..783807249 100644
--- a/arch/arm64/boot/dts/exynos/Makefile
+++ b/arch/arm64/boot/dts/exynos/Makefile
@@ -10,5 +10,6 @@ dtb-$(CONFIG_ARCH_EXYNOS) += \
 	exynos8895-dreamlte.dtb		\
 	exynos990-c1s.dtb		\
 	exynos990-x1s.dtb		\
+	exynos990-x1slte.dtb		\
 	exynosautov9-sadk.dtb		\
 	exynosautov920-sadk.dtb
diff --git a/arch/arm64/boot/dts/exynos/exynos990-x1slte.dts b/arch/arm64/boot/dts/exynos/exynos990-x1slte.dts
new file mode 100644
index 000000000..9e6a1a060
--- /dev/null
+++ b/arch/arm64/boot/dts/exynos/exynos990-x1slte.dts
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
+/*
+ * Samsung Galaxy S20 (x1slte/SM-G980F) device tree source
+ *
+ * Copyright (c) 2024, Umer Uddin <umer.uddin@mentallysanemainliners.org>
+ */
+
+/dts-v1/;
+#include "exynos990-hubble-common.dtsi"
+
+/ {
+	#address-cells = <2>;
+	#size-cells = <2>;
+
+	model = "Samsung Galaxy S20";
+	compatible = "samsung,x1slte", "samsung,exynos990";
+};
-- 
2.47.0

Re: [PATCH v2 1/4] dt-bindings: arm: samsung: samsung-boards: Add bindings for SM-G981B and SM-G980F board

[Krzysztof Kozlowski]

On Thu, Oct 17, 2024 at 05:43:24PM +0100, Umer Uddin wrote:
> Add devicetree bindings for Samsung Galaxy S20 5G
> and Samsung Galaxy S20 board.
> 
> Signed-off-by: Umer Uddin <umer.uddin@mentallysanemainliners.org>
> ---
>  .../devicetree/bindings/arm/samsung/samsung-boards.yaml         | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> index d25a17e69..70a915240 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> @@ -234,6 +234,8 @@ properties:
>          items:
>            - enum:
>                - samsung,c1s                     # Samsung Galaxy Note20 5G (SM-N981B)
> +              - samsung,x1s                     # Samsung Galaxy S20 5G (SM-G981B)
> +	      - samsung,x1slte			# Samsung Galaxy S20 (SM-G980F)

It does not look like you tested the bindings, at least after quick
look. Please run 'make dt_binding_check' (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.

Best regards,
Krzysztof

Re: [PATCH v2 4/4] arm64: dts: exynos: Add initial support for Samsung Galaxy S20 (x1slte)

[Krzysztof Kozlowski]

On Thu, Oct 17, 2024 at 05:43:27PM +0100, Umer Uddin wrote:
> Add initial support for the Samsung Galaxy S20 (x1slte/SM-G980F)
> phone. It was launched in 2020, and it's based on the Exynos 990 SoC. It
> has only one configuration with 8GB of RAM and 128GB of UFS 3.0 storage.

8 GB RAM, so the memory map should not be the same (and should not be in
DTSI file).

> 
> This device tree adds support for the following:
> 
> - SimpleFB
> - 8GB RAM
> - Buttons

Best regards,
Krzysztof

Re: [PATCH v2 2/4] arm64: dts: exynos: Add initial support for Samsung Galaxy S20 Series boards (hubble)

[Krzysztof Kozlowski]

On Thu, Oct 17, 2024 at 05:43:25PM +0100, Umer Uddin wrote:
> Add initial support for the Samsung Galaxy S20 Series (hubble) phones.
> They were launched in 2020, and are based on the Exynos 990 SoC.
> The devices have multiple RAM configurations,
> starting from 8GB going all the way up to 16GB for the S20 Ultra devices.
> 
> This device tree adds support for the following:
> 
> - SimpleFB
> - 8GB RAM (Any more will be mapped in device trees)
> - Buttons
> 
> Signed-off-by: Umer Uddin <umer.uddin@mentallysanemainliners.org>
> ---
>  .../dts/exynos/exynos990-hubble-common.dtsi   | 109 ++++++++++++++++++
>  1 file changed, 109 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/exynos/exynos990-hubble-common.dtsi
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos990-hubble-common.dtsi b/arch/arm64/boot/dts/exynos/exynos990-hubble-common.dtsi
> new file mode 100644
> index 000000000..2c634e4bb
> --- /dev/null
> +++ b/arch/arm64/boot/dts/exynos/exynos990-hubble-common.dtsi
> @@ -0,0 +1,109 @@
> +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
> +/*
> + * Samsung Galaxy S20 Series device tree source
> + *
> + * Copyright (c) 2024, Umer Uddin <umer.uddin@mentallysanemainliners.org>
> + */
> +
> +/dts-v1/;
> +#include "exynos990.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +
> +/ {
> +	chosen {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		framebuffer0: framebuffer@f1000000 {
> +			compatible = "simple-framebuffer";
> +			reg = <0 0xf1000000 0 (1440 * 3200 * 4)>;
> +			width = <1440>;
> +			height = <3200>;
> +			stride = <(1440 * 4)>;
> +			format = "a8r8g8b8";
> +		};
> +	};
> +
> +	memory@80000000 {
> +		device_type = "memory";
> +		reg = <0x0 0x80000000 0x0 0x3ab00000>,
> +		      /* Memory hole */
> +		      <0x0 0xc1200000 0x0 0x1ee00000>,
> +		      /* Memory hole */
> +		      <0x0 0xe1900000 0x0 0x1e700000>,
> +		      /* Memory hole */
> +		      <0x8 0x80000000 0x1 0x7ec00000>;


If I am counting correctly, that's only 8 GB, not 12.

Best regards,
Krzysztof

Re: Re: [PATCH v2 0/4] Add minimal Samsung Galaxy S20 Series board, SM-G981B and SM-G980F support

[Umer Uddin]

On Thu, Oct 17, 2024 at 05:43:27PM +0100, Umer Uddin wrote:
> > Add initial support for the Samsung Galaxy S20 (x1slte/SM-G980F)
> > phone. It was launched in 2020, and it's based on the Exynos 990 SoC. It
> > has only one configuration with 8GB of RAM and 128GB of UFS 3.0 storage.

> 8 GB RAM, so the memory map should not be the same (and should not be in
> DTSI file).

> >
> > This device tree adds support for the following:
> >
> > - SimpleFB
> > - 8GB RAM
> > - Buttons

Best regards,
Krzysztof

Hi Krzysztof,

Thank you for the review.
All hubble devices actually do
have the first 8GB of RAM mapped the same, I have personally
checked this, by getting fdt dumps from /sys/firmware/fdt
and checking all of the memory nodes.

Best regards,
Umer

Re: [PATCH v2 0/4] Add minimal Samsung Galaxy S20 Series board, SM-G981B and SM-G980F support

[Krzysztof Kozlowski]

On 18/10/2024 08:48, Umer Uddin wrote:
> On Thu, Oct 17, 2024 at 05:43:27PM +0100, Umer Uddin wrote:
>>> Add initial support for the Samsung Galaxy S20 (x1slte/SM-G980F)
>>> phone. It was launched in 2020, and it's based on the Exynos 990 SoC. It
>>> has only one configuration with 8GB of RAM and 128GB of UFS 3.0 storage.
> 
>> 8 GB RAM, so the memory map should not be the same (and should not be in
>> DTSI file).
> 
>>>
>>> This device tree adds support for the following:
>>>
>>> - SimpleFB
>>> - 8GB RAM
>>> - Buttons
> 
> Best regards,
> Krzysztof
> 
> Hi Krzysztof,
> 
> Thank you for the review.
> All hubble devices actually do
> have the first 8GB of RAM mapped the same, I have personally
> checked this, by getting fdt dumps from /sys/firmware/fdt
> and checking all of the memory nodes.
> 

What about remaining 4 GB on X1S?

Best regards,
Krzysztof

Re: [PATCH v2 0/4] Add minimal Samsung Galaxy S20 Series board, SM-G981B and SM-G980F support

[Rob Herring (Arm)]

On Thu, 17 Oct 2024 17:43:23 +0100, Umer Uddin wrote:
> Hi folks,
> 
> This series adds initial support for the Samsung Galaxy S20 Series, also
> initial board support for the Samsung Galaxy S20 5G (SM-G981B)
> codenamed x1s and the Samsung Galaxy S20 (SM-G980F) codenamed
> x1slte.
> 
> The S20 Series feature a lot of similarities in their configuration
> and internally Samsung named the common devicetrees in their
> downstream kernel 'hubble', please note hubble excludes the
> S20 FE series and Note20 series.
> The device trees have been tested with dtbs_check W=1
> and results in no warnings.
> 
> This initial bringup consists of:
>  * pinctrl
>  * gpio-keys
>  * simple-framebuffer
> 
> This is enough to reach a shell in an initramfs. More platform support
> will be added in the future.
> 
> Just like SM-N981B, the preferred way to boot the upstream kernel is
> by using a shim bootloader, called uniLoader [1], which works around
> some issues with the stock, non-replacable Samsung S-LK bootloader.
> For example, the stock bootloader leaves the decon trigger control
> unset, which causes the framebuffer not to refresh.
> 
> Device functionality depends on the patch series from Igor Belwon:
> "Add minimal Exynos990 SoC and SM-N981B support"
> 
> [1] https://github.com/ivoszbg/uniLoader
> 
> Changes in v2:
>  - Add Samsung Galaxy S20 into device tree bindings
>  - Add support for Samsung Galaxy S20 as well as the 5G variant now
>  - Fix typo in Samsung Galaxy S20 5G commit message
> 
> Kind regards,
> Umer
> 
> Umer Uddin (4):
>   dt-bindings: arm: samsung: samsung-boards: Add bindings for SM-G981B
>     and SM-G980F board
>   arm64: dts: exynos: Add initial support for Samsung Galaxy S20 Series
>     boards (hubble)
>   arm64: dts: exynos: Add initial support for Samsung Galaxy S20 5G
>     (x1s)
>   arm64: dts: exynos: Add initial support for Samsung Galaxy S20
>     (x1slte)
> 
>  .../bindings/arm/samsung/samsung-boards.yaml  |   2 +
>  arch/arm64/boot/dts/exynos/Makefile           |   2 +
>  .../dts/exynos/exynos990-hubble-common.dtsi   | 109 ++++++++++++++++++
>  arch/arm64/boot/dts/exynos/exynos990-x1s.dts  |  23 ++++
>  .../boot/dts/exynos/exynos990-x1slte.dts      |  17 +++
>  5 files changed, 153 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/exynos/exynos990-hubble-common.dtsi
>  create mode 100644 arch/arm64/boot/dts/exynos/exynos990-x1s.dts
>  create mode 100644 arch/arm64/boot/dts/exynos/exynos990-x1slte.dts
> 
> --
> 2.47.0
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y exynos/exynos990-x1s.dtb exynos/exynos990-x1slte.dtb' for 20241017164328.17077-1-umer.uddin@mentallysanemainliners.org:

arch/arm64/boot/dts/exynos/exynos990-x1slte.dtb: /: failed to match any schema with compatible: ['samsung,x1slte', 'samsung,exynos990']
arch/arm64/boot/dts/exynos/exynos990-x1slte.dtb: /: failed to match any schema with compatible: ['samsung,x1slte', 'samsung,exynos990']
arch/arm64/boot/dts/exynos/exynos990-x1s.dtb: /: failed to match any schema with compatible: ['samsung,x1s', 'samsung,exynos990']
arch/arm64/boot/dts/exynos/exynos990-x1s.dtb: /: failed to match any schema with compatible: ['samsung,x1s', 'samsung,exynos990']

Re: Re: [PATCH v2 0/4] Add minimal Samsung Galaxy S20 Series board, SM-G981B and SM-G980F support

[Umer Uddin]

On Fri, 18 Oct 2024 09:14:01 +0200, Krzysztof Kozlowski wrote:

> What about remaining 4 GB on X1S?

On x1s, the remaining memory is mapped in the device specific dtsi.

Best regards,
Umer

Re: [PATCH v2 0/4] Add minimal Samsung Galaxy S20 Series board, SM-G981B and SM-G980F support

[Krzysztof Kozlowski]

On 18/10/2024 18:20, Umer Uddin wrote:
> On Fri, 18 Oct 2024 09:14:01 +0200, Krzysztof Kozlowski wrote:
> 
>> What about remaining 4 GB on X1S?
> 
> On x1s, the remaining memory is mapped in the device specific dtsi.

Then it proves that this is not correctly placed - not a shared part of
boards. Remove it from DTSI.

Best regards,
Krzysztof