From: Bart Van Assche <bvanassche@acm.org>
To: linan666@huaweicloud.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, mcgrof@kernel.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linan122@huawei.com, yukuai3@huawei.com, yi.zhang@huawei.com,
houtao1@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH] scsi: sd: unregister device if device_add_disk() failed in sd_probe()
Date: Mon, 1 Apr 2024 10:49:50 -0700 [thread overview]
Message-ID: <1c65d12e-3821-4cae-a268-4f2755ad53af@acm.org> (raw)
In-Reply-To: <20231208082335.1754205-1-linan666@huaweicloud.com>
On 12/8/23 00:23, linan666@huaweicloud.com wrote:
> From: Li Nan <linan122@huawei.com>
>
> "if device_add() succeeds, you should call device_del() when you want to
> get rid of it."
>
> In sd_probe(), device_add_disk() fails when device_add() has already
> succeeded, so change put_device() to device_unregister() to ensure device
> resources are released.
>
> Fixes: 2a7a891f4c40 ("scsi: sd: Add error handling support for add_disk()")
> Signed-off-by: Li Nan <linan122@huawei.com>
> ---
> drivers/scsi/sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index 542a4bbb21bc..d81cbeee06eb 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -3736,7 +3736,7 @@ static int sd_probe(struct device *dev)
>
> error = device_add_disk(dev, gd, NULL);
> if (error) {
> - put_device(&sdkp->disk_dev);
> + device_unregister(&sdkp->disk_dev);
> put_disk(gd);
> goto out;
> }
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2024-04-01 17:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 8:23 linan666
2023-12-22 6:49 ` Luis Chamberlain
2023-12-22 8:27 ` Yu Kuai
2024-01-29 17:46 ` Luis Chamberlain
2024-01-30 1:30 ` Yu Kuai
2024-01-29 13:26 ` Li Nan
2024-02-22 9:24 ` Li Nan
2024-04-01 1:31 ` Yu Kuai
2024-04-01 17:51 ` Bart Van Assche
2024-04-02 0:16 ` Damien Le Moal
2024-04-01 17:49 ` Bart Van Assche [this message]
2024-04-02 1:48 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c65d12e-3821-4cae-a268-4f2755ad53af@acm.org \
--to=bvanassche@acm.org \
--cc=houtao1@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=linan122@huawei.com \
--cc=linan666@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®