From: Damien Le Moal <dlemoal@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>,
Yu Kuai <yukuai1@huaweicloud.com>,
linan666@huaweicloud.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, mcgrof@kernel.org, hch@lst.de,
"yukuai (C)" <yukuai3@huawei.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linan122@huawei.com, yi.zhang@huawei.com, houtao1@huawei.com,
yangerkun@huawei.com
Subject: Re: [PATCH] scsi: sd: unregister device if device_add_disk() failed in sd_probe()
Date: Tue, 2 Apr 2024 09:16:30 +0900 [thread overview]
Message-ID: <f02767b9-66e9-43ad-bc81-3a6b40ff852c@kernel.org> (raw)
In-Reply-To: <2af548ae-8877-4e8d-8dc2-541b3d6e6330@acm.org>
On 4/2/24 02:51, Bart Van Assche wrote:
> On 3/31/24 18:31, Yu Kuai wrote:
>> I was shocked that this patch is still there. This patch is easy and
>> straightforward.
>>
>> LGTM
>> Reviewed-by: Yu Kuai <yukuai3@huawei.com>
>>
>> BTW, Nan, it will be better if you have a reporducer for this.
> Agreed that a reproducer would help. No information is present in the
> patch description about how this issue was detected nor about how it was
> tested. That probably would have encouraged reviewers.
May be submit the reproducer as a blktest case while at it ?
>
> Bart.
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-04-02 0:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 8:23 linan666
2023-12-22 6:49 ` Luis Chamberlain
2023-12-22 8:27 ` Yu Kuai
2024-01-29 17:46 ` Luis Chamberlain
2024-01-30 1:30 ` Yu Kuai
2024-01-29 13:26 ` Li Nan
2024-02-22 9:24 ` Li Nan
2024-04-01 1:31 ` Yu Kuai
2024-04-01 17:51 ` Bart Van Assche
2024-04-02 0:16 ` Damien Le Moal [this message]
2024-04-01 17:49 ` Bart Van Assche
2024-04-02 1:48 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f02767b9-66e9-43ad-bc81-3a6b40ff852c@kernel.org \
--to=dlemoal@kernel.org \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=houtao1@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=linan122@huawei.com \
--cc=linan666@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®