From: Hugh Dickins <hughd@google.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Hugh Dickins <hughd@google.com>, Sagi Grimberg <sagi@grimberg.me>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Thorsten Leemhuis <regressions@leemhuis.info>,
regressions@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v3] net: fix rc7's __skb_datagram_iter()
Date: Wed, 10 Jul 2024 09:36:48 -0700 (PDT) [thread overview]
Message-ID: <1c72ac52-9830-c2f9-5a14-d1487da8fabf@google.com> (raw)
In-Reply-To: <934ac0b8491ec56dd35b9f0ab7422daa1926c4df.camel@redhat.com>
On Wed, 10 Jul 2024, Paolo Abeni wrote:
> On Wed, 2024-07-10 at 08:36 -0700, Hugh Dickins wrote:
> > X would not start in my old 32-bit partition (and the "n"-handling looks
> > just as wrong on 64-bit, but for whatever reason did not show up there):
> > "n" must be accumulated over all pages before it's added to "offset" and
> > compared with "copy", immediately after the skb_frag_foreach_page() loop.
> >
> > Fixes: d2d30a376d9c ("net: allow skb_datagram_iter to be called from any context")
> > Signed-off-by: Hugh Dickins <hughd@google.com>
> > Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> > ---
> > v3: added reviewed-by Sagi, try sending direct to Linus
>
> V2 is already applied to the 'net' tree and will be included in our
> next 'net' PR, coming tomorrow.
>
> It looks like the netdev bot decided it needed an holiday (or was
> fooled by the threaded submission for v2), so no notification landed on
> the ML.
>
> @Hugh: next time please check the current tree status or patchwork
> before submitting a new revision. And please avoid submitting the new
> version in reply to a previous one, it makes things difficult for our
> CI.
Ah, great, thanks. Yes, I'd heard only silence (and was worried because,
although I only saw the effect of this on 32-bit, suspect it could cause
lots of obscure trouble more generally).
Hugh
next prev parent reply other threads:[~2024-07-10 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 3:00 [PATCH] " Hugh Dickins
2024-07-08 6:21 ` Sagi Grimberg
2024-07-08 14:46 ` [PATCH v2] " Hugh Dickins
2024-07-08 14:47 ` Sagi Grimberg
2024-07-10 15:36 ` [PATCH v3] " Hugh Dickins
2024-07-10 16:19 ` Paolo Abeni
2024-07-10 16:36 ` Hugh Dickins [this message]
2024-07-11 20:43 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c72ac52-9830-c2f9-5a14-d1487da8fabf@google.com \
--to=hughd@google.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=sagi@grimberg.me \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®