mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Linux regression tracking (Thorsten Leemhuis)"  <regressions@leemhuis.info>
To: "Georg Müller" <georgmueller@gmx.net>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Jiri Olsa" <jolsa@kernel.org>,
	"Namhyung Kim" <namhyung@kernel.org>,
	"Ian Rogers" <irogers@google.com>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: regressions@lists.linux.dev,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] perf probe: fix regression introduced by switch to die_get_decl_file
Date: Mon, 10 Jul 2023 14:32:28 +0200	[thread overview]
Message-ID: <1c85c4d6-7097-bc0a-d0ca-ebe234d63ece@leemhuis.info> (raw)
In-Reply-To: <20230628084551.1860532-3-georgmueller@gmx.net>

Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
for once, to make this easily accessible to everyone.

Masami, Arnaldo, what's up here? Georg (who is not a regular
contributor) afaics found a regression in a commit you
authored/committed and even provided a patch-set to fix it (the first
one nearly four weeks ago, e.g. before the merge window started), but
hasn't received much support from your side to get this in. Could you
please look into this to get this cleared up? Or am I missing something
and progress to fix this has been made?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.


On 28.06.23 10:45, Georg Müller wrote:
> When switching from dwarf_decl_file() to die_get_decl_file(), a regression
> was introduced when having a binary where the DWARF info is split to
> multiple CUs. It is not possible to add probes to certain functions.
> 
> These patches introduce a testcase which shows the current regression
> and a fix for the issue
> 
> Signed-off-by: Georg Müller <georgmueller@gmx.net>
> Link: https://lore.kernel.org/r/5a00d5a5-7be7-ef8a-4044-9a16249fff25@gmx.net/
> 
> ---
> Changes in v2:
>  - Add testcase
> 
> Changes in v3:
>  - start new thread
>  - add stable to cc
> 
> Georg Müller (2):
>   perf probe: add test for regression introduced by switch to
>     die_get_decl_file
>   perf probe: read DWARF files from the correct CU
> 
>  .../shell/test_uprobe_from_different_cu.sh    | 77 +++++++++++++++++++
>  tools/perf/util/dwarf-aux.c                   |  4 +-
>  2 files changed, 80 insertions(+), 1 deletion(-)
>  create mode 100755 tools/perf/tests/shell/test_uprobe_from_different_cu.sh
> 
> --
> 2.41.0
> 
> 
> 

  parent reply	other threads:[~2023-07-10 12:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28  8:45 Georg Müller
2023-06-28  8:45 ` [PATCH v3 1/2] perf probe: add test for " Georg Müller
2023-06-28  8:45 ` [PATCH v3 2/2] perf probe: read DWARF files from the correct CU Georg Müller
2023-07-10 12:32 ` Linux regression tracking (Thorsten Leemhuis) [this message]
2023-07-10 13:44   ` [PATCH v3 0/2] perf probe: fix regression introduced by switch to die_get_decl_file Arnaldo Carvalho de Melo
2023-07-10 13:49     ` Linux regression tracking (Thorsten Leemhuis)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c85c4d6-7097-bc0a-d0ca-ebe234d63ece@leemhuis.info \
    --to=regressions@leemhuis.info \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=georgmueller@gmx.net \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®