From: "jiale yao" <19888972804@163.com>
To: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Marc Zyngier" <maz@kernel.org>,
"Thomas Gleixner" <tglx@kernel.org>,
"Radu Rendec" <radu@rendec.net>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re:[PATCH 4/6] irqchip/gic-v5-its: validate MADT translate frames
Date: Sat, 17 Oct 2026 15:30:44 +0800 (CST) [thread overview]
Message-ID: <1c8e50a6.184c.1a148c52fb0.Coremail.19888972804@163.com> (raw)
In-Reply-To: <20261016141357.2793046-5-yaojiale02@163.com>
At 2026-10-16 22:13:55, "Jiale Yao" <yaojiale02@163.com> wrote:
>The GICv5 ITS translate-frame callback accesses IDs and the base address
>without checking that the MADT entry contains the complete fixed-size
>record. A truncated firmware entry can therefore cause out-of-bounds
>reads.
>
>Reject incomplete translate-frame entries before using their fields.
>
Fixes: a97efa5ba594 ("irqchip/gic-v5: Add ACPI ITS probing")
>Signed-off-by: Jiale Yao <yaojiale02@163.com>
>---
> drivers/irqchip/irq-gic-v5-its.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
>index 28e39b065de0..dad3b95ba150 100644
>--- a/drivers/irqchip/irq-gic-v5-its.c
>+++ b/drivers/irqchip/irq-gic-v5-its.c
>@@ -1233,6 +1233,9 @@ static int __init gic_acpi_parse_madt_its_translate(union acpi_subtable_headers
> int err;
>
> its_frame = (struct acpi_madt_gicv5_translate_frame *)header;
>+ if (BAD_MADT_ENTRY(its_frame, end))
>+ return -EINVAL;
>+
> if (its_frame->linked_translator_id != current_its_entry->translator_id)
> return 0;
>
>--
>2.34.1
next prev parent reply other threads:[~2026-10-17 7:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 14:13 [PATCH 0/6] irqchip: validate ACPI MADT entries before use Jiale Yao
2026-10-16 14:13 ` [PATCH 1/6] ACPI: irqchip: validate MADT entry bounds before probing Jiale Yao
2026-10-17 7:28 ` jiale yao
2026-10-16 14:13 ` [PATCH 2/6] irqchip/gic-v3-its: validate MADT ITS entries Jiale Yao
2026-10-17 7:29 ` jiale yao
2026-10-16 14:13 ` [PATCH 3/6] irqchip/gic-v3: validate MADT records before use Jiale Yao
2026-10-16 14:36 ` Marc Zyngier
2026-10-16 14:52 ` jiale yao
2026-10-17 7:29 ` jiale yao
2026-10-16 14:13 ` [PATCH 4/6] irqchip/gic-v5-its: validate MADT translate frames Jiale Yao
2026-10-17 7:30 ` jiale yao [this message]
2026-10-16 14:13 ` [PATCH 5/6] irqchip/loongarch-cpu: validate MADT LIO-PIC entries Jiale Yao
2026-10-17 7:31 ` jiale yao
2026-10-16 14:13 ` [PATCH 6/6] irqchip/loongson-eiointc: validate MADT BIO-PIC entries Jiale Yao
2026-10-17 7:32 ` jiale yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c8e50a6.184c.1a148c52fb0.Coremail.19888972804@163.com \
--to=19888972804@163.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=radu@rendec.net \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®