mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "jiale yao" <19888972804@163.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re:[PATCH 1/6] ACPI: irqchip: validate MADT entry bounds before probing
Date: Sat, 17 Oct 2026 15:28:21 +0800 (CST)	[thread overview]
Message-ID: <49c1871f.181e.1a148c2ff14.Coremail.19888972804@163.com> (raw)
In-Reply-To: <20261016141357.2793046-2-yaojiale02@163.com>

At 2026-10-16 22:13:52, "Jiale Yao" <yaojiale02@163.com> wrote:
>IRQ chip probing invokes validation and probe callbacks after the common
>table walker has only established that a generic subtable header is
>readable. A malformed length can leave callback field accesses outside
>the MADT.
>
>Validate the generic header length and ensure the complete declared
>entry is contained in the table before invoking IRQ chip callbacks.
>

Fixes: e647b532275b ("ACPI: Add early device probing infrastructure")

>Signed-off-by: Jiale Yao <yaojiale02@163.com>
>---
> drivers/acpi/scan.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
>index 163a3cccf197..ef8e8441b6ef 100644
>--- a/drivers/acpi/scan.c
>+++ b/drivers/acpi/scan.c
>@@ -2889,6 +2889,13 @@ static DEFINE_MUTEX(acpi_probe_mutex);
> static int __init acpi_match_madt(union acpi_subtable_headers *header,
> 				  const unsigned long end)
> {
>+	unsigned long start = (unsigned long)header;
>+
>+	if (start >= end || end - start < sizeof(header->common) ||
>+	    header->common.length < sizeof(header->common) ||
>+	    header->common.length > end - start)
>+		return -EINVAL;
>+
> 	if (!ape->subtable_valid || ape->subtable_valid(&header->common, ape))
> 		if (!ape->probe_subtbl(header, end))
> 			acpi_probe_count++;
>-- 
>2.34.1

  reply	other threads:[~2026-10-17  7:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 14:13 [PATCH 0/6] irqchip: validate ACPI MADT entries before use Jiale Yao
2026-10-16 14:13 ` [PATCH 1/6] ACPI: irqchip: validate MADT entry bounds before probing Jiale Yao
2026-10-17  7:28   ` jiale yao [this message]
2026-10-16 14:13 ` [PATCH 2/6] irqchip/gic-v3-its: validate MADT ITS entries Jiale Yao
2026-10-17  7:29   ` jiale yao
2026-10-16 14:13 ` [PATCH 3/6] irqchip/gic-v3: validate MADT records before use Jiale Yao
2026-10-16 14:36   ` Marc Zyngier
2026-10-16 14:52     ` jiale yao
2026-10-17  7:29   ` jiale yao
2026-10-16 14:13 ` [PATCH 4/6] irqchip/gic-v5-its: validate MADT translate frames Jiale Yao
2026-10-17  7:30   ` jiale yao
2026-10-16 14:13 ` [PATCH 5/6] irqchip/loongarch-cpu: validate MADT LIO-PIC entries Jiale Yao
2026-10-17  7:31   ` jiale yao
2026-10-16 14:13 ` [PATCH 6/6] irqchip/loongson-eiointc: validate MADT BIO-PIC entries Jiale Yao
2026-10-17  7:32   ` jiale yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49c1871f.181e.1a148c2ff14.Coremail.19888972804@163.com \
    --to=19888972804@163.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®