From: Saravanan Sekar <saravanan@linumiz.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
linux@roeck-us.net, jdelvare@suse.com,
linux-kernel@vger.kernel.org, marten.lindahl@axis.com
Subject: Re: [PATCH v2 3/4] hwmon: (pmbus/mpq7932) Add a support for mpq7932 Power Management IC
Date: Thu, 1 Dec 2022 12:36:50 +0100 [thread overview]
Message-ID: <1c989c0a-e66d-9c57-5932-0fa5599ef8ad@linumiz.com> (raw)
In-Reply-To: <f28da7ab-920d-a534-9f5d-e8407d0487a9@linaro.org>
On 01/12/22 11:26, Krzysztof Kozlowski wrote:
> On 01/12/2022 05:46, Saravanan Sekar wrote:
>> The MPQ7932 is a power management IC designed to operate from 5V buses to
>> power a variety of Advanced driver-assistance system SOCs. Six integrated
>> buck converters with hardware monitoring capability powers a variety of
>> target rails configurable over PMBus interface.
>>
>> Signed-off-by: Saravanan Sekar <saravanan@linumiz.com>
>> ---
>> drivers/hwmon/pmbus/Kconfig | 10 +++
>> drivers/hwmon/pmbus/Makefile | 1 +
>> drivers/hwmon/pmbus/mpq7932.c | 144 ++++++++++++++++++++++++++++++++++
>> 3 files changed, 155 insertions(+)
>> create mode 100644 drivers/hwmon/pmbus/mpq7932.c
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
Thank you again for your time for review.
I saw two comments from you on V1 which I believe addressed on V2
1. Missing maybe_unused, so drop of_match_ptr.
".of_match_table = of_match_ptr(mpq7932_of_match)"
dropped of_match_ptr.
2. It's a regulator, not hwmon.
"config SENSORS_MPQ7932_REGULATOR
tristate "MPS MPQ7932 buck regulator" "
It is PMIC chip with hwmon support access over PMBUS.
Please help if anything I missed
> Thank you.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2022-12-01 11:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 4:46 [PATCH v2 0/4] Add support for mpq7932 PMIC IC Saravanan Sekar
2022-12-01 4:46 ` [PATCH v2 1/4] hwmon: pm_bus: core: Add min_uV in pmbus regulator helper macro Saravanan Sekar
2022-12-01 4:46 ` [PATCH v2 2/4] dt-bindings: hwmon/pmbus: Add mps,mpq7932 power-management IC Saravanan Sekar
2022-12-01 10:26 ` Krzysztof Kozlowski
2022-12-01 11:29 ` Saravanan Sekar
2022-12-01 11:38 ` Krzysztof Kozlowski
2022-12-01 15:37 ` Guenter Roeck
2022-12-01 15:57 ` Saravanan Sekar
2022-12-01 16:15 ` Krzysztof Kozlowski
2022-12-01 16:38 ` Saravanan Sekar
2022-12-01 16:43 ` Krzysztof Kozlowski
2022-12-01 16:52 ` Saravanan Sekar
2022-12-01 17:00 ` Krzysztof Kozlowski
2022-12-01 13:36 ` Rob Herring
2022-12-01 16:16 ` Krzysztof Kozlowski
2022-12-01 4:46 ` [PATCH v2 3/4] hwmon: (pmbus/mpq7932) Add a support for mpq7932 Power Management IC Saravanan Sekar
2022-12-01 10:26 ` Krzysztof Kozlowski
2022-12-01 11:36 ` Saravanan Sekar [this message]
2022-12-01 15:34 ` Guenter Roeck
2022-12-07 3:51 ` Saravanan Sekar
2022-12-07 4:46 ` Guenter Roeck
2022-12-01 4:46 ` [PATCH v2 4/4] MAINTAINERS: Update the entry for MPQ7932 PMIC driver Saravanan Sekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c989c0a-e66d-9c57-5932-0fa5599ef8ad@linumiz.com \
--to=saravanan@linumiz.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marten.lindahl@axis.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®