* [PATCH] tools/bpf:Fix the wrong format specifier
@ 2024-07-24 6:42 Zhu Jun
2024-07-24 8:17 ` Geliang Tang
2024-07-24 8:48 ` Quentin Monnet
0 siblings, 2 replies; 3+ messages in thread
From: Zhu Jun @ 2024-07-24 6:42 UTC (permalink / raw)
To: qmo
Cc: ast, daniel, martin.lau, eddyz87, song, yonghong.song,
john.fastabend, kpsingh, sdf, haoluo, bpf, linux-kernel, Zhu Jun
The unsigned int should use "%u" instead of "%d".
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
tools/bpf/bpftool/xlated_dumper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/bpf/bpftool/xlated_dumper.c b/tools/bpf/bpftool/xlated_dumper.c
index 567f56dfd9f1..3efa639434be 100644
--- a/tools/bpf/bpftool/xlated_dumper.c
+++ b/tools/bpf/bpftool/xlated_dumper.c
@@ -349,7 +349,7 @@ void dump_xlated_plain(struct dump_data *dd, void *buf, unsigned int len,
double_insn = insn[i].code == (BPF_LD | BPF_IMM | BPF_DW);
- printf("% 4d: ", i);
+ printf("% 4u: ", i);
print_bpf_insn(&cbs, insn + i, true);
if (opcodes) {
@@ -415,7 +415,7 @@ void dump_xlated_for_graph(struct dump_data *dd, void *buf_start, void *buf_end,
}
}
- printf("%d: ", insn_off);
+ printf("%u: ", insn_off);
print_bpf_insn(&cbs, cur, true);
if (opcodes) {
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tools/bpf:Fix the wrong format specifier
2024-07-24 6:42 [PATCH] tools/bpf:Fix the wrong format specifier Zhu Jun
@ 2024-07-24 8:17 ` Geliang Tang
2024-07-24 8:48 ` Quentin Monnet
1 sibling, 0 replies; 3+ messages in thread
From: Geliang Tang @ 2024-07-24 8:17 UTC (permalink / raw)
To: Zhu Jun, qmo
Cc: ast, daniel, martin.lau, eddyz87, song, yonghong.song,
john.fastabend, kpsingh, sdf, haoluo, bpf, linux-kernel
On Tue, 2024-07-23 at 23:42 -0700, Zhu Jun wrote:
> The unsigned int should use "%u" instead of "%d".
I guess you mean:
The format specifier of "unsigned int" in printf() should be "%u", not
"%d".
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Acked-by: Geliang Tang <geliang@kernel.org>
> ---
> tools/bpf/bpftool/xlated_dumper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/bpf/bpftool/xlated_dumper.c
> b/tools/bpf/bpftool/xlated_dumper.c
> index 567f56dfd9f1..3efa639434be 100644
> --- a/tools/bpf/bpftool/xlated_dumper.c
> +++ b/tools/bpf/bpftool/xlated_dumper.c
> @@ -349,7 +349,7 @@ void dump_xlated_plain(struct dump_data *dd, void
> *buf, unsigned int len,
>
> double_insn = insn[i].code == (BPF_LD | BPF_IMM |
> BPF_DW);
>
> - printf("% 4d: ", i);
> + printf("% 4u: ", i);
> print_bpf_insn(&cbs, insn + i, true);
>
> if (opcodes) {
> @@ -415,7 +415,7 @@ void dump_xlated_for_graph(struct dump_data *dd,
> void *buf_start, void *buf_end,
> }
> }
>
> - printf("%d: ", insn_off);
> + printf("%u: ", insn_off);
> print_bpf_insn(&cbs, cur, true);
>
> if (opcodes) {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tools/bpf:Fix the wrong format specifier
2024-07-24 6:42 [PATCH] tools/bpf:Fix the wrong format specifier Zhu Jun
2024-07-24 8:17 ` Geliang Tang
@ 2024-07-24 8:48 ` Quentin Monnet
1 sibling, 0 replies; 3+ messages in thread
From: Quentin Monnet @ 2024-07-24 8:48 UTC (permalink / raw)
To: Zhu Jun
Cc: ast, daniel, martin.lau, eddyz87, song, yonghong.song,
john.fastabend, kpsingh, sdf, haoluo, bpf, linux-kernel
2024-07-23 23:42 UTC-0700 ~ Zhu Jun <zhujun2@cmss.chinamobile.com>
> The unsigned int should use "%u" instead of "%d".
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> ---
> tools/bpf/bpftool/xlated_dumper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/bpf/bpftool/xlated_dumper.c b/tools/bpf/bpftool/xlated_dumper.c
> index 567f56dfd9f1..3efa639434be 100644
> --- a/tools/bpf/bpftool/xlated_dumper.c
> +++ b/tools/bpf/bpftool/xlated_dumper.c
> @@ -349,7 +349,7 @@ void dump_xlated_plain(struct dump_data *dd, void *buf, unsigned int len,
>
> double_insn = insn[i].code == (BPF_LD | BPF_IMM | BPF_DW);
>
> - printf("% 4d: ", i);
> + printf("% 4u: ", i);
Thanks! But did you try to compile this? It produces a warning:
xlated_dumper.c: In function ‘dump_xlated_plain’:
xlated_dumper.c:352:28: warning: ' ' flag used with ‘%u’ gnu_printf format [-Wformat=]
352 | printf("% 4u: ", i);
| ^
Please fix it.
Quentin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-24 8:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-24 6:42 [PATCH] tools/bpf:Fix the wrong format specifier Zhu Jun
2024-07-24 8:17 ` Geliang Tang
2024-07-24 8:48 ` Quentin Monnet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®