mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: defconfig: Enable PINCTRL_S32G2
@ 2026-11-02 14:16 Khristine Andreea Barbulescu
  2026-11-02 14:24 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: Khristine Andreea Barbulescu @ 2026-11-02 14:16 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Chester Lin, Matthias Brugger,
	Ghennadi Procopciuc, Larisa Grigore, Lee Jones, Shawn Guo,
	Sascha Hauer, Fabio Estevam, Dong Aisheng, Jacky Bai,
	Greg Kroah-Hartman, Rafael J. Wysocki, Srinivas Kandagatla
  Cc: Alberto Ruiz, Christophe Lizzi, devicetree, Enric Balletbo,
	Eric Chanudet, imx, linux-arm-kernel, linux-gpio, linux-kernel,
	NXP S32 Linux Team, Pengutronix Kernel Team, Vincent Guittot

Enable the NXP S32G2 pin controller driver in the arm64 defconfig so it
no longer requires a manual "make menuconfig" step. The symbol selects
PINCTRL_S32CC, pulling in the common S32 pin controller support used
across the S32G family.

Signed-off-by: Khristine Andreea Barbulescu <khristineandreea.barbulescu@oss.nxp.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 7b4985b29b21..545a2b7db8a5 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -704,6 +704,7 @@ CONFIG_PINCTRL_BCM2712=y
 CONFIG_PINCTRL_SKY1=y
 CONFIG_PINCTRL_IMX_SCMI=y
 CONFIG_PINCTRL_IMX91=y
+CONFIG_PINCTRL_S32G2=y
 CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
 CONFIG_PINCTRL_LPASS_LPI=m
 CONFIG_PINCTRL_MILOS_LPASS_LPI=m
-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: defconfig: Enable PINCTRL_S32G2
  2026-11-02 14:16 [PATCH] arm64: defconfig: Enable PINCTRL_S32G2 Khristine Andreea Barbulescu
@ 2026-11-02 14:24 ` Greg Kroah-Hartman
  2026-11-02 14:49   ` Khristine Andreea Barbulescu
  0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2026-11-02 14:24 UTC (permalink / raw)
  To: Khristine Andreea Barbulescu
  Cc: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Chester Lin, Matthias Brugger,
	Ghennadi Procopciuc, Larisa Grigore, Lee Jones, Shawn Guo,
	Sascha Hauer, Fabio Estevam, Dong Aisheng, Jacky Bai,
	Rafael J. Wysocki, Srinivas Kandagatla, Alberto Ruiz,
	Christophe Lizzi, devicetree, Enric Balletbo, Eric Chanudet, imx,
	linux-arm-kernel, linux-gpio, linux-kernel, NXP S32 Linux Team,
	Pengutronix Kernel Team, Vincent Guittot

On Mon, Nov 02, 2026 at 03:16:35PM +0100, Khristine Andreea Barbulescu wrote:
> Enable the NXP S32G2 pin controller driver in the arm64 defconfig so it
> no longer requires a manual "make menuconfig" step. The symbol selects
> PINCTRL_S32CC, pulling in the common S32 pin controller support used
> across the S32G family.
> 
> Signed-off-by: Khristine Andreea Barbulescu <khristineandreea.barbulescu@oss.nxp.com>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 7b4985b29b21..545a2b7db8a5 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -704,6 +704,7 @@ CONFIG_PINCTRL_BCM2712=y
>  CONFIG_PINCTRL_SKY1=y
>  CONFIG_PINCTRL_IMX_SCMI=y
>  CONFIG_PINCTRL_IMX91=y
> +CONFIG_PINCTRL_S32G2=y

Why?  Shouldn't the normal platform-specific defconfig work for this
instead?  what defines the arm64 defconfig to require this now for all
arm74 platforms?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: defconfig: Enable PINCTRL_S32G2
  2026-11-02 14:24 ` Greg Kroah-Hartman
@ 2026-11-02 14:49   ` Khristine Andreea Barbulescu
  2026-11-02 14:55     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Khristine Andreea Barbulescu @ 2026-11-02 14:49 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Chester Lin, Matthias Brugger,
	Ghennadi Procopciuc, Larisa Grigore, Lee Jones, Shawn Guo,
	Sascha Hauer, Fabio Estevam, Dong Aisheng, Jacky Bai,
	Rafael J. Wysocki, Srinivas Kandagatla, Alberto Ruiz,
	Christophe Lizzi, devicetree, Enric Balletbo, Eric Chanudet, imx,
	linux-arm-kernel, linux-gpio, linux-kernel, NXP S32 Linux Team,
	Pengutronix Kernel Team, Vincent Guittot

On 11/2/2026 4:24 PM, Greg Kroah-Hartman wrote:
> On Mon, Nov 02, 2026 at 03:16:35PM +0100, Khristine Andreea Barbulescu wrote:
>> Enable the NXP S32G2 pin controller driver in the arm64 defconfig so it
>> no longer requires a manual "make menuconfig" step. The symbol selects
>> PINCTRL_S32CC, pulling in the common S32 pin controller support used
>> across the S32G family.
>>
>> Signed-off-by: Khristine Andreea Barbulescu <khristineandreea.barbulescu@oss.nxp.com>
>> ---
>>  arch/arm64/configs/defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 7b4985b29b21..545a2b7db8a5 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -704,6 +704,7 @@ CONFIG_PINCTRL_BCM2712=y
>>  CONFIG_PINCTRL_SKY1=y
>>  CONFIG_PINCTRL_IMX_SCMI=y
>>  CONFIG_PINCTRL_IMX91=y
>> +CONFIG_PINCTRL_S32G2=y
> 
> Why?  Shouldn't the normal platform-specific defconfig work for this
> instead?  what defines the arm64 defconfig to require this now for all
> arm74 platforms?
> 
> thanks,
> 
> greg k-h

Hello Greg,

ARCH_S32 is already enabled in the arm64 defconfig, but the supported
S32G boards also depend on this pin controller for their pin muxing.
Without it, some peripherals never finish probing, so a defconfig kernel
cannot boot to rootfs on these boards.

Regards,
Khristine

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: defconfig: Enable PINCTRL_S32G2
  2026-11-02 14:49   ` Khristine Andreea Barbulescu
@ 2026-11-02 14:55     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-02 14:55 UTC (permalink / raw)
  To: Khristine Andreea Barbulescu, Greg Kroah-Hartman
  Cc: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Chester Lin, Matthias Brugger,
	Ghennadi Procopciuc, Larisa Grigore, Lee Jones, Shawn Guo,
	Sascha Hauer, Fabio Estevam, Dong Aisheng, Jacky Bai,
	Rafael J. Wysocki, Srinivas Kandagatla, Alberto Ruiz,
	Christophe Lizzi, devicetree, Enric Balletbo, Eric Chanudet, imx,
	linux-arm-kernel, linux-gpio, linux-kernel, NXP S32 Linux Team,
	Pengutronix Kernel Team, Vincent Guittot

On 02/11/2026 15:49, Khristine Andreea Barbulescu wrote:
> On 11/2/2026 4:24 PM, Greg Kroah-Hartman wrote:
>> On Mon, Nov 02, 2026 at 03:16:35PM +0100, Khristine Andreea Barbulescu wrote:
>>> Enable the NXP S32G2 pin controller driver in the arm64 defconfig so it
>>> no longer requires a manual "make menuconfig" step. The symbol selects
>>> PINCTRL_S32CC, pulling in the common S32 pin controller support used
>>> across the S32G family.

Well, my standard request - why would we want it? You need to list the
upstream board(s) needing it. We do not develop defconfig for downstream.


Also, odd CC-list, really random.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

>>>
>>> Signed-off-by: Khristine Andreea Barbulescu <khristineandreea.barbulescu@oss.nxp.com>
>>> ---
>>>  arch/arm64/configs/defconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 7b4985b29b21..545a2b7db8a5 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -704,6 +704,7 @@ CONFIG_PINCTRL_BCM2712=y
>>>  CONFIG_PINCTRL_SKY1=y
>>>  CONFIG_PINCTRL_IMX_SCMI=y
>>>  CONFIG_PINCTRL_IMX91=y
>>> +CONFIG_PINCTRL_S32G2=y
>>
>> Why?  Shouldn't the normal platform-specific defconfig work for this
>> instead?  what defines the arm64 defconfig to require this now for all
>> arm74 platforms?
>>
>> thanks,
>>
>> greg k-h
> 
> Hello Greg,
> 
> ARCH_S32 is already enabled in the arm64 defconfig, but the supported
> S32G boards also depend on this pin controller for their pin muxing.
> Without it, some peripherals never finish probing, so a defconfig kernel
> cannot boot to rootfs on these boards.

Greg has valid point, you did not really address it. Explain why it
should be user-selectable choice in the first place.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-02 14:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-02 14:16 [PATCH] arm64: defconfig: Enable PINCTRL_S32G2 Khristine Andreea Barbulescu
2026-11-02 14:24 ` Greg Kroah-Hartman
2026-11-02 14:49   ` Khristine Andreea Barbulescu
2026-11-02 14:55     ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®