* [PATCH] blk-mq-sched: Remove redundant code in blk_mq_sched_mark_restart_hctx().
@ 2026-01-16 6:19 Chaohai Chen
2026-01-16 7:32 ` Yu Kuai
0 siblings, 1 reply; 2+ messages in thread
From: Chaohai Chen @ 2026-01-16 6:19 UTC (permalink / raw)
To: axboe, linux-block, linux-kernel; +Cc: Chaohai Chen
The current purpose of the blk_mq_sched_mark_restart_hctx() function
is to set the BLK_MQ_S_SCHED_RESTART flag in hctx->state. Just remove
the redundant judgement.
Signed-off-by: Chaohai Chen <wdhh6@aliyun.com>
---
block/blk-mq-sched.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
index e26898128a7e..2f6c353cb6d0 100644
--- a/block/blk-mq-sched.c
+++ b/block/blk-mq-sched.c
@@ -21,9 +21,6 @@
*/
void blk_mq_sched_mark_restart_hctx(struct blk_mq_hw_ctx *hctx)
{
- if (test_bit(BLK_MQ_S_SCHED_RESTART, &hctx->state))
- return;
-
set_bit(BLK_MQ_S_SCHED_RESTART, &hctx->state);
}
EXPORT_SYMBOL_GPL(blk_mq_sched_mark_restart_hctx);
--
2.43.7
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] blk-mq-sched: Remove redundant code in blk_mq_sched_mark_restart_hctx().
2026-01-16 6:19 [PATCH] blk-mq-sched: Remove redundant code in blk_mq_sched_mark_restart_hctx() Chaohai Chen
@ 2026-01-16 7:32 ` Yu Kuai
0 siblings, 0 replies; 2+ messages in thread
From: Yu Kuai @ 2026-01-16 7:32 UTC (permalink / raw)
To: Chaohai Chen, axboe, linux-block, linux-kernel, yukuai
Hi,
在 2026/1/16 14:19, Chaohai Chen 写道:
> The current purpose of the blk_mq_sched_mark_restart_hctx() function
> is to set the BLK_MQ_S_SCHED_RESTART flag in hctx->state. Just remove
> the redundant judgement.
I don't think this is just redundant. This function is called from IO hot path,
and test_bit() should have less performance overhead than set_bit() if the
state is already set.
>
> Signed-off-by: Chaohai Chen <wdhh6@aliyun.com>
> ---
> block/blk-mq-sched.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
> index e26898128a7e..2f6c353cb6d0 100644
> --- a/block/blk-mq-sched.c
> +++ b/block/blk-mq-sched.c
> @@ -21,9 +21,6 @@
> */
> void blk_mq_sched_mark_restart_hctx(struct blk_mq_hw_ctx *hctx)
> {
> - if (test_bit(BLK_MQ_S_SCHED_RESTART, &hctx->state))
> - return;
> -
> set_bit(BLK_MQ_S_SCHED_RESTART, &hctx->state);
> }
> EXPORT_SYMBOL_GPL(blk_mq_sched_mark_restart_hctx);
--
Thansk,
Kuai
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-16 7:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-16 6:19 [PATCH] blk-mq-sched: Remove redundant code in blk_mq_sched_mark_restart_hctx() Chaohai Chen
2026-01-16 7:32 ` Yu Kuai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®