From: Markus Elfring <Markus.Elfring@web.de>
To: Mark Brown <broonie@kernel.org>,
Navid Emamdoost <navid.emamdoost@gmail.com>,
linux-spi@vger.kernel.org
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen McCamant <smccaman@umn.edu>, Qiushi Wu <wu000273@umn.edu>,
Dinghao Liu <dinghao.liu@zju.edu.cn>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure
Date: Tue, 2 Jun 2020 21:54:49 +0200 [thread overview]
Message-ID: <1d1a4e7a-1c1e-efeb-ad61-5e4f1eeecab1@web.de> (raw)
In-Reply-To: <20200602183644.GI5684@sirena.org.uk>
> Your updates were not improvements.
I find your view interesting.
Do you refer to a specific wording suggestion here?
https://lore.kernel.org/linux-spi/26028f50-3fb8-eb08-3c9f-08ada018bf9e@web.de/
https://lkml.org/lkml/2020/6/2/210
You pointed another programming alternative out.
https://lore.kernel.org/patchwork/comment/1447149/
https://lore.kernel.org/linux-spi/20200602095411.GB5684@sirena.org.uk/
> The formatting was worse
Do you prefer an other quotation style for function names?
> and to my native speaker eyes the grammar was worse.
I am curious if a more pleasing wording variant will be found.
> With this sort of stylistic thing it's especially important
> that any review aligns with the needs and practices of the subsystem,
Such an expectation is reasonable to some degree.
> there is opinion in there and multiple opinions just makes things harder
> for submitters.
Do any of such views deviate from the Linux development documentation?
Regards,
Markus
prev parent reply other threads:[~2020-06-02 19:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 8:40 [PATCH] " Markus Elfring
2020-06-02 9:49 ` Mark Brown
2020-06-02 10:02 ` Markus Elfring
2020-06-02 14:13 ` Mark Brown
2020-06-02 15:05 ` Markus Elfring
2020-06-02 18:36 ` Mark Brown
2020-06-02 19:35 ` Navid Emamdoost
2020-06-02 19:54 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d1a4e7a-1c1e-efeb-ad61-5e4f1eeecab1@web.de \
--to=markus.elfring@web.de \
--cc=broonie@kernel.org \
--cc=dinghao.liu@zju.edu.cn \
--cc=emamd001@umn.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=smccaman@umn.edu \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®