From: Markus Elfring <Markus.Elfring@web.de>
To: Mark Brown <broonie@kernel.org>,
Navid Emamdoost <navid.emamdoost@gmail.com>,
linux-spi@vger.kernel.org
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen McCamant <smccaman@umn.edu>, Qiushi Wu <wu000273@umn.edu>,
Dinghao Liu <dinghao.liu@zju.edu.cn>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure
Date: Tue, 2 Jun 2020 17:05:18 +0200 [thread overview]
Message-ID: <cc8e1397-c605-d73e-363e-9d2ddfb9ae16@web.de> (raw)
In-Reply-To: <20200602141306.GH5684@sirena.org.uk>
>> I find this commit message improvable also according to Linux software
>> development documentation.
>
> Causing people to send out new versions of things for tweaks to the
> commit log consumes time for them and everyone they're sending changes to.
Improving patches (besides source code adjustments) is an usual software
development activity, isn't it?
> Pushing people to make trivial rewordings of their commit logs to
> match your particular taste is not a good use of people's time.
Corresponding tweaks can be combined with recommended tags.
It can be that only “trivial” items were left over for another bit
of fine-tuning. Subsequent description variants can reduce
the probability for additional patch review iterations, can't they?
Regards,
Markus
next prev parent reply other threads:[~2020-06-02 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 8:40 [PATCH] " Markus Elfring
2020-06-02 9:49 ` Mark Brown
2020-06-02 10:02 ` Markus Elfring
2020-06-02 14:13 ` Mark Brown
2020-06-02 15:05 ` Markus Elfring [this message]
2020-06-02 18:36 ` Mark Brown
2020-06-02 19:35 ` Navid Emamdoost
2020-06-02 19:54 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc8e1397-c605-d73e-363e-9d2ddfb9ae16@web.de \
--to=markus.elfring@web.de \
--cc=broonie@kernel.org \
--cc=dinghao.liu@zju.edu.cn \
--cc=emamd001@umn.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=smccaman@umn.edu \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®