mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Williams <john.williams@petalogix.com>
To: Michal Simek <michal.simek@petalogix.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: microblaze: commit 95521585 breakage
Date: Thu, 17 Sep 2009 15:46:26 +1000	[thread overview]
Message-ID: <1d3f23370909162246v308da10aga5c4c76d5584341b@mail.gmail.com> (raw)

Hi Sam, Michal,

Your MicroBlaze arch makefile cleanup commit
9552158573f847aa429334bb97995bb290bb4b0d had a rather unfortunate
error in it:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=950b260ed21fdb6fa5f18485dabb0b03488431fa

You intended to change CFLAGS_KERNEL to KBUILD_CFLAGS, but instead
changed CFLAGS_KERNEL to KBUILD_KERNEL.

The result?  No CPU feature optimisations across the entire MicroBlaze
kernel build :(

The fix is trivial - may I leave it to you to resolve and merge as
soon as possible?  This is a pretty serious performance regression.

Thanks,

John
-- 
John Williams, PhD, B.Eng, B.IT
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com  p: +61-7-30090663  f: +61-7-30090663

             reply	other threads:[~2009-09-17  5:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-17  5:46 John Williams [this message]
2009-09-19  9:07 ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d3f23370909162246v308da10aga5c4c76d5584341b@mail.gmail.com \
    --to=john.williams@petalogix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@petalogix.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®