From: Sam Ravnborg <sam@ravnborg.org>
To: John Williams <john.williams@petalogix.com>
Cc: Michal Simek <michal.simek@petalogix.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: microblaze: commit 95521585 breakage
Date: Sat, 19 Sep 2009 11:07:08 +0200 [thread overview]
Message-ID: <20090919090708.GD25877@merkur.ravnborg.org> (raw)
In-Reply-To: <1d3f23370909162246v308da10aga5c4c76d5584341b@mail.gmail.com>
On Thu, Sep 17, 2009 at 03:46:26PM +1000, John Williams wrote:
> Hi Sam, Michal,
>
> Your MicroBlaze arch makefile cleanup commit
> 9552158573f847aa429334bb97995bb290bb4b0d had a rather unfortunate
> error in it:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=950b260ed21fdb6fa5f18485dabb0b03488431fa
>
> You intended to change CFLAGS_KERNEL to KBUILD_CFLAGS, but instead
> changed CFLAGS_KERNEL to KBUILD_KERNEL.
>
> The result? No CPU feature optimisations across the entire MicroBlaze
> kernel build :(
>
> The fix is trivial - may I leave it to you to resolve and merge as
> soon as possible? This is a pretty serious performance regression.
Agree with the analysis of John.
Michael - I leave it to you to fix it up.
Sam
prev parent reply other threads:[~2009-09-19 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 5:46 John Williams
2009-09-19 9:07 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090919090708.GD25877@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=john.williams@petalogix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@petalogix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®