From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: dgilbert@redhat.com, jmattson@google.com,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: SVM: relax conditions for allowing MSR_IA32_SPEC_CTRL accesses
Date: Thu, 6 Feb 2020 15:21:37 +0100 [thread overview]
Message-ID: <1d7f50a2-3c3f-dd18-a635-aa4eaa757fa3@redhat.com> (raw)
In-Reply-To: <87v9ojg5r1.fsf@vitty.brq.redhat.com>
On 06/02/20 15:17, Vitaly Kuznetsov wrote:
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> but out of pure curiosity, why do we need these checks?
>
> At least for the 'set' case right below them we have:
>
> if (data & ~kvm_spec_ctrl_valid_bits(vcpu))
> return 1;
>
> so if guest will try using unsupported features it will #GP. So
> basically, these checks will only fire when reading/writing '0' and all
> features are missing, right? Do we care?
Probably not... I just wanted the smallest possible change in semantics
for this patch, and the rest can be done equally on Intel and AMD.
Paolo
prev parent reply other threads:[~2020-02-06 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 15:13 Paolo Bonzini
2020-02-06 14:17 ` Vitaly Kuznetsov
2020-02-06 14:21 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d7f50a2-3c3f-dd18-a635-aa4eaa757fa3@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®