From: Jens Axboe <axboe@kernel.dk>
To: Xianting Tian <tian.xianting@h3c.com>, raghavendra.kt@linux.vnet.ibm.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
mhocko@suse.com
Subject: Re: [PATCH] blk-mq: remove the calling of local_memory_node()
Date: Tue, 20 Oct 2020 07:08:49 -0600 [thread overview]
Message-ID: <1db7f790-b4df-435b-25b1-d99222ed7c50@kernel.dk> (raw)
In-Reply-To: <20201019082047.31113-1-tian.xianting@h3c.com>
On 10/19/20 2:20 AM, Xianting Tian wrote:
> We don't need to check whether the node is memoryless numa node before
> calling allocator interface. SLUB(and SLAB,SLOB) relies on the page
> allocator to pick a node. Page allocator should deal with memoryless
> nodes just fine. It has zonelists constructed for each possible nodes.
> And it will automatically fall back into a node which is closest to the
> requested node. As long as __GFP_THISNODE is not enforced of course.
>
> The code comments of kmem_cache_alloc_node() of SLAB also showed this:
> * Fallback to other node is possible if __GFP_THISNODE is not set.
>
> blk-mq code doesn't set __GFP_THISNODE, so we can remove the calling
> of local_memory_node().
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-10-20 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 8:20 Xianting Tian
2020-10-19 11:40 ` Michal Hocko
2020-10-20 2:52 ` Tianxianting
2020-10-20 13:08 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1db7f790-b4df-435b-25b1-d99222ed7c50@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=tian.xianting@h3c.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome