mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3] arm64: dts: qcom: sdm845: Introduce camera master clock pinctrl
@ 2026-01-14 10:08 David Heidelberg via B4 Relay
  2026-02-04 16:53 ` David Heidelberg
  2026-03-10  2:45 ` Bjorn Andersson
  0 siblings, 2 replies; 4+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-01-14 10:08 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Vladimir Zapolskiy
  Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
	Konrad Dybcio, David Heidelberg

From: David Heidelberg <david@ixit.cz>

Put clock pins configuration for camera master clock into the dtsi.

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Inspired by Richard's patch set for SDM670, I noticed that SDM845
follows the same pattern. This change prepares for enabling
additional cameras.

These pinctrl settings have been verified against the downstream
SDM845 kernel.

Since most of these are not yet used in mainline, testing was done
on sdm845-next using OnePlus 6 cameras with downstream drivers.

Thank you
David
---
Changes in v3:
- Dropped 2nd patch
  ("arm64: dts: qcom: sdm845-db845c: Use pad fn instead of defining own")
  as there is no documentation or people who can answer questions for
  now, so we can move forward with the main camera work.
- Link to v2: https://lore.kernel.org/r/20251217-sdm845-mclk-v2-0-7028c2d09145@ixit.cz

Changes in v2:
- Added mclk3. (Vladimir)
- Reword commit messages.
- Corrected commit msg name. (Konrad)
- Link to v1: https://lore.kernel.org/r/20251213-sdm845-mclk-v1-0-197bc947d4c6@ixit.cz
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 56 ++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index bf2f9c04adba7..c0f21a745fb0c 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2805,6 +2805,62 @@ tlmm: pinctrl@3400000 {
 			gpio-ranges = <&tlmm 0 0 151>;
 			wakeup-parent = <&pdc_intc>;
 
+			cam_mclk0_default: cam-mclk0-default-state {
+				pins = "gpio13";
+				function = "cam_mclk";
+				drive-strength = <2>;
+				bias-disable;
+			};
+
+			cam_mclk0_sleep: cam-mclk0-sleep-state {
+				pins = "gpio13";
+				function = "cam_mclk";
+				drive-strength = <2>;
+				bias-pull-down;
+			};
+
+			cam_mclk1_default: cam-mclk1-default-state {
+				pins = "gpio14";
+				function = "cam_mclk";
+				drive-strength = <2>;
+				bias-disable;
+			};
+
+			cam_mclk1_sleep: cam-mclk1-sleep-state {
+				pins = "gpio14";
+				function = "cam_mclk";
+				drive-strength = <2>;
+				bias-pull-down;
+			};
+
+			cam_mclk2_default: cam-mclk2-default-state {
+				pins = "gpio15";
+				function = "cam_mclk";
+				drive-strength = <2>;
+				bias-disable;
+			};
+
+			cam_mclk2_sleep: cam-mclk2-sleep-state {
+				pins = "gpio15";
+				function = "cam_mclk";
+				drive-strength = <2>;
+				bias-pull-down;
+			};
+
+			cam_mclk3_default: cam-mclk3-default-state {
+				pins = "gpio16";
+				function = "cam_mclk";
+				drive-strength = <2>;
+				bias-disable;
+			};
+
+			cam_mclk3_sleep: cam-mclk3-sleep-state {
+				pins = "gpio16";
+				function = "cam_mclk";
+				drive-strength = <2>;
+				bias-pull-down;
+			};
+
 			cci0_default: cci0-default-state {
 				/* SDA, SCL */
 				pins = "gpio17", "gpio18";

---
base-commit: 0f853ca2a798ead9d24d39cad99b0966815c582a
change-id: 20251213-sdm845-mclk-041f2a952e31

Best regards,
-- 
David Heidelberg <david@ixit.cz>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] arm64: dts: qcom: sdm845: Introduce camera master clock pinctrl
  2026-01-14 10:08 [PATCH v3] arm64: dts: qcom: sdm845: Introduce camera master clock pinctrl David Heidelberg via B4 Relay
@ 2026-02-04 16:53 ` David Heidelberg
  2026-02-04 16:56   ` Konrad Dybcio
  2026-03-10  2:45 ` Bjorn Andersson
  1 sibling, 1 reply; 4+ messages in thread
From: David Heidelberg @ 2026-02-04 16:53 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Vladimir Zapolskiy
  Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, Konrad Dybcio

On 14/01/2026 11:08, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> Put clock pins configuration for camera master clock into the dtsi.
> 
> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Inspired by Richard's patch set for SDM670, I noticed that SDM845
> follows the same pattern. This change prepares for enabling
> additional cameras.
> 
> These pinctrl settings have been verified against the downstream
> SDM845 kernel.
> 
> Since most of these are not yet used in mainline, testing was done
> on sdm845-next using OnePlus 6 cameras with downstream drivers.
> 
> Thank you
> David
> ---
> Changes in v3:
> - Dropped 2nd patch
>    ("arm64: dts: qcom: sdm845-db845c: Use pad fn instead of defining own")
>    as there is no documentation or people who can answer questions for
>    now, so we can move forward with the main camera work.
> - Link to v2: https://lore.kernel.org/r/20251217-sdm845-mclk-v2-0-7028c2d09145@ixit.cz
> 
> Changes in v2:
> - Added mclk3. (Vladimir)
> - Reword commit messages.
> - Corrected commit msg name. (Konrad)
> - Link to v1: https://lore.kernel.org/r/20251213-sdm845-mclk-v1-0-197bc947d4c6@ixit.cz
> ---
>   arch/arm64/boot/dts/qcom/sdm845.dtsi | 56 ++++++++++++++++++++++++++++++++++++
>   1 file changed, 56 insertions(+)
> 

Hello, reminder this lovely patch exist :)

Thanks,
David

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] arm64: dts: qcom: sdm845: Introduce camera master clock pinctrl
  2026-02-04 16:53 ` David Heidelberg
@ 2026-02-04 16:56   ` Konrad Dybcio
  0 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2026-02-04 16:56 UTC (permalink / raw)
  To: David Heidelberg, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Vladimir Zapolskiy
  Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel

On 2/4/26 5:53 PM, David Heidelberg wrote:
> On 14/01/2026 11:08, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> Put clock pins configuration for camera master clock into the dtsi.
>>
>> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> Inspired by Richard's patch set for SDM670, I noticed that SDM845
>> follows the same pattern. This change prepares for enabling
>> additional cameras.
>>
>> These pinctrl settings have been verified against the downstream
>> SDM845 kernel.
>>
>> Since most of these are not yet used in mainline, testing was done
>> on sdm845-next using OnePlus 6 cameras with downstream drivers.
>>
>> Thank you
>> David
>> ---
>> Changes in v3:
>> - Dropped 2nd patch
>>    ("arm64: dts: qcom: sdm845-db845c: Use pad fn instead of defining own")
>>    as there is no documentation or people who can answer questions for
>>    now, so we can move forward with the main camera work.
>> - Link to v2: https://lore.kernel.org/r/20251217-sdm845-mclk-v2-0-7028c2d09145@ixit.cz
>>
>> Changes in v2:
>> - Added mclk3. (Vladimir)
>> - Reword commit messages.
>> - Corrected commit msg name. (Konrad)
>> - Link to v1: https://lore.kernel.org/r/20251213-sdm845-mclk-v1-0-197bc947d4c6@ixit.cz
>> ---
>>   arch/arm64/boot/dts/qcom/sdm845.dtsi | 56 ++++++++++++++++++++++++++++++++++++
>>   1 file changed, 56 insertions(+)
>>
> 
> Hello, reminder this lovely patch exist :)

We can only follow it up with a reminder of the kernel dev cycle..

The "merge window" as confusingly as it's named, is for Linus to merge
patches from maintainers downstream of him. New features will be accepted
after rc1 drops (circa 3 weeks)

Konrad

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] arm64: dts: qcom: sdm845: Introduce camera master clock pinctrl
  2026-01-14 10:08 [PATCH v3] arm64: dts: qcom: sdm845: Introduce camera master clock pinctrl David Heidelberg via B4 Relay
  2026-02-04 16:53 ` David Heidelberg
@ 2026-03-10  2:45 ` Bjorn Andersson
  1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2026-03-10  2:45 UTC (permalink / raw)
  To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Vladimir Zapolskiy, David Heidelberg
  Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, Konrad Dybcio


On Wed, 14 Jan 2026 11:08:45 +0100, David Heidelberg wrote:
> Put clock pins configuration for camera master clock into the dtsi.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sdm845: Introduce camera master clock pinctrl
      commit: 7ffe83b6178e1668cf17ab4d9394dc2873c3aa17

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-03-10  2:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-14 10:08 [PATCH v3] arm64: dts: qcom: sdm845: Introduce camera master clock pinctrl David Heidelberg via B4 Relay
2026-02-04 16:53 ` David Heidelberg
2026-02-04 16:56   ` Konrad Dybcio
2026-03-10  2:45 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®